arm64: errata: Add -mpc-relative-literal-loads to build flags
PATCH v2 1/1 arm64: errata: Add -mpc-relative-literal-loads to build flags
GCC6 (and Linaro's 2015.12 snapshot of GCC5) has a new default that uses adrp/ldr or adrp/add to address literal pools. When CONFIG_ARM64_ERRATUM_843419 is enabled, modules built with this toolchain fail to load:
[ 2.156817] module libahci: unsupported RELA relocation: 275
Longterm, this will likely be superseded by -mfix-cortex-a53-843419, which should disable this optimization in the future.
v2: Unconditionally use flag for both kernel and modules, as Ard notes we have no requirement for supporting literals >1 MB away.
--- arch/arm64/Makefile | 1 + 1 file changed, 1 insertion(+)
arch/arm64/Makefile +1 -0
@@ -27,6 +27,7 @@ $(warning LSE atomics not supported by binutils) endif KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) +KBUILD_CFLAGS += $(call cc-option, -mpc-relative-literal-loads) KBUILD_AFLAGS += $(lseinstr) ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
Signature · 1 line
2.7.0
PATCH v2 1/1 arm64: errata: Add -mpc-relative-literal-loads to build flags
Quoted 9 lines · dann frazier
GCC6 (and Linaro's 2015.12 snapshot of GCC5) has a new default that uses adrp/ldr or adrp/add to address literal pools. When
CONFIG_ARM64_ERRATUM_843419is enabled, modules built with this toolchain fail to load:[ 2.156817] module libahci: unsupported RELA relocation: 275Longterm, this will likely be superseded by -mfix-cortex-a53-843419, which should disable this optimization in the future.
Better drop this line, it does not apply to partially linked object files (aka modules), only to fully linked binaries [afaik]
Quoted 3 lines
v2: Unconditionally use flag for both kernel and modules, as Ard notes we have no requirement for supporting literals >1 MB away.
Quoted 24 lines
Cc stable at vger.kernel.orgFixes df057cc7b4fa ("arm64: errata: add module build workaround for erratum #843419")Suggested-by Christophe Lyon <[email protected]>Signed-off-by dann frazier <[email protected]>--- arch/arm64/Makefile | 1 + 1 file changed, 1 insertion(+)arch/arm64/Makefile +1
-1@@ -27,6 +27,7 @@ $(warning LSE atomics not supported by binutils) endif KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) +KBUILD_CFLAGS += $(call cc-option, -mpc-relative-literal-loads) KBUILD_AFLAGS += $(lseinstr) ifeq ($(CONFIG_CPU_BIG_ENDIAN), y) --2.7.0