Skip to contentSkip to conversation

intel_scu_ipcutil: underflow in scu_reg_access()

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 26, 2016 – Jan 30, 2016

Subsystems (4)
Kernel janitors x86 platform drivers Intel MID (Mobile Internet Device) platform Intel scu drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 intel_scu_ipcutil: underflow in scu_reg_access()

"count" is controlled by the user and it can be negative. Let's prevent that by making it unsigned. You have to have CAP_SYS_RAWIO to call this function so the bug is not as serious as it could be.

Fixes 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by Dan Carpenter <[email protected]>
drivers/platform/x86/intel_scu_ipcutil.c +1 -1
index 02bc5a6..aa45424 100644
@@ -49,7 +49,7 @@ struct scu_ipc_data {
 
 static int scu_reg_access(u32 cmd, struct scu_ipc_data  *data)
 {
-	int count = data->count;
+	unsigned int count = data->count;
 
 	if (count = 0 || count = 3 || count > 4)
 		return -EINVAL;
Applied
#1 lore raw
Quoted 6 lines · Dan Carpenter

"count" is controlled by the user and it can be negative. Let's prevent that by making it unsigned. You have to have CAP_SYS_RAWIO to call this function so the bug is not as serious as it could be.

Fixes 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by Dan Carpenter <[email protected]>

Queued to fixes for 4.5-rc1 as well as stable.

Thanks Dan,

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center