Skip to contentSkip to conversation

sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58

PATCH Julia Lawall 4 participants 4 messages Jan 26, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201601261604.CeDxAxPv%[email protected]

#1 lore raw

It looks like braces are missing here.

julia

Quoted 35 lines · kbuild test robot

CC: [email protected]
CC: [email protected]
TO: Lucas Tanure <[email protected]>
CC: Takashi Iwai <[email protected]>
CC: Takashi Sakamoto <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
commit: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 [5/5] ALSA: bebob: Use a signed return type for get_formation_index

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58

git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git remote update sound
git checkout a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
vim +57 sound/firewire/bebob/bebob_stream.c

a1d35f23 Lucas Tanure     2016-01-25  51  get_formation_index(unsigned int rate, unsigned int *index)
eb7b3a05 Takashi Sakamoto 2014-04-25  52  {
eb7b3a05 Takashi Sakamoto 2014-04-25  53  	unsigned int i;
eb7b3a05 Takashi Sakamoto 2014-04-25  54
eb7b3a05 Takashi Sakamoto 2014-04-25  55  	for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) {
eb7b3a05 Takashi Sakamoto 2014-04-25  56  		if (snd_bebob_rate_table[i] == rate)
a1d35f23 Lucas Tanure     2016-01-25 @57  			*index = i;
a1d35f23 Lucas Tanure     2016-01-25 @58  			return 0;
eb7b3a05 Takashi Sakamoto 2014-04-25  59  	}
eb7b3a05 Takashi Sakamoto 2014-04-25  60  	return -EINVAL;
eb7b3a05 Takashi Sakamoto 2014-04-25  61  }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#2 lore raw

Hi,

Quoted 34 lines · Julia Lawall

It looks like braces are missing here.

julia

Quoted 27 lines · kbuild test robot

CC: [email protected]
CC: [email protected]
TO: Lucas Tanure <[email protected]>
CC: Takashi Iwai <[email protected]>
CC: Takashi Sakamoto <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
commit: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 [5/5] ALSA: bebob: Use a signed return type for get_formation_index

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58

git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git remote update sound
git checkout a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
vim +57 sound/firewire/bebob/bebob_stream.c

a1d35f23 Lucas Tanure     2016-01-25  51  get_formation_index(unsigned int rate, unsigned int *index)
eb7b3a05 Takashi Sakamoto 2014-04-25  52  {
eb7b3a05 Takashi Sakamoto 2014-04-25  53      unsigned int i;
eb7b3a05 Takashi Sakamoto 2014-04-25  54
eb7b3a05 Takashi Sakamoto 2014-04-25  55      for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) {
eb7b3a05 Takashi Sakamoto 2014-04-25  56              if (snd_bebob_rate_table[i] == rate)
a1d35f23 Lucas Tanure     2016-01-25 @57                      *index = i;
a1d35f23 Lucas Tanure     2016-01-25 @58                      return 0;

Sorry, my mistake. I will resend.

Quoted 8 lines
Quoted 8 lines
eb7b3a05 Takashi Sakamoto 2014-04-25  59      }
eb7b3a05 Takashi Sakamoto 2014-04-25  60      return -EINVAL;
eb7b3a05 Takashi Sakamoto 2014-04-25  61  }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Thanks!

--
Lucas Tanure

#3 lore raw
In reply to Julia Lawall
Quoted 2 lines · Julia Lawall

It looks like braces are missing here.

Indeed. Corrected the patch now. Thanks!

Takashi

Quoted 41 lines

julia

Quoted 35 lines · kbuild test robot

CC: [email protected]
CC: [email protected]
TO: Lucas Tanure <[email protected]>
CC: Takashi Iwai <[email protected]>
CC: Takashi Sakamoto <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
commit: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 [5/5] ALSA: bebob: Use a signed return type for get_formation_index

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58

git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git remote update sound
git checkout a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
vim +57 sound/firewire/bebob/bebob_stream.c

a1d35f23 Lucas Tanure     2016-01-25  51  get_formation_index(unsigned int rate, unsigned int *index)
eb7b3a05 Takashi Sakamoto 2014-04-25  52  {
eb7b3a05 Takashi Sakamoto 2014-04-25  53  	unsigned int i;
eb7b3a05 Takashi Sakamoto 2014-04-25  54
eb7b3a05 Takashi Sakamoto 2014-04-25  55  	for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) {
eb7b3a05 Takashi Sakamoto 2014-04-25  56  		if (snd_bebob_rate_table[i] == rate)
a1d35f23 Lucas Tanure     2016-01-25 @57  			*index = i;
a1d35f23 Lucas Tanure     2016-01-25 @58  			return 0;
eb7b3a05 Takashi Sakamoto 2014-04-25  59  	}
eb7b3a05 Takashi Sakamoto 2014-04-25  60  	return -EINVAL;
eb7b3a05 Takashi Sakamoto 2014-04-25  61  }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#4 lore raw
Quoted 12 lines · Takashi Iwai
Quoted 2 lines · Julia Lawall

It looks like braces are missing here.

Indeed. Corrected the patch now. Thanks!

Takashi

Quoted 2 lines

julia

Oh... Thanks for every persons to fix it.
(and I should have took enough rest...)

Quoted 32 lines
Quoted 32 lines · kbuild test robot
Quoted 31 lines

CC: [email protected]
CC: [email protected]
TO: Lucas Tanure <[email protected]>
CC: Takashi Iwai <[email protected]>
CC: Takashi Sakamoto <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
commit: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 [5/5] ALSA: bebob: Use a signed return type for get_formation_index

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58

git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git remote update sound
git checkout a1d35f23965e7c0175ddecb1af0ae287c4e0aa23
vim +57 sound/firewire/bebob/bebob_stream.c

a1d35f23 Lucas Tanure     2016-01-25  51  get_formation_index(unsigned int rate, unsigned int *index)
eb7b3a05 Takashi Sakamoto 2014-04-25  52  {
eb7b3a05 Takashi Sakamoto 2014-04-25  53  	unsigned int i;
eb7b3a05 Takashi Sakamoto 2014-04-25  54
eb7b3a05 Takashi Sakamoto 2014-04-25  55  	for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) {
eb7b3a05 Takashi Sakamoto 2014-04-25  56  		if (snd_bebob_rate_table[i] == rate)
a1d35f23 Lucas Tanure     2016-01-25 @57  			*index = i;
a1d35f23 Lucas Tanure     2016-01-25 @58  			return 0;
eb7b3a05 Takashi Sakamoto 2014-04-25  59  	}
eb7b3a05 Takashi Sakamoto 2014-04-25  60  	return -EINVAL;
eb7b3a05 Takashi Sakamoto 2014-04-25  61  }