Skip to contentSkip to conversation

fs: btrfs: fixes a pass by reference issue in send.c

PATCH In review Ben Marsh 2 participants 2 messages Feb 1, 2016 Btrfs file system

lore
Share & tools
lore

Ben Marsh

author
#0 lore raw

PATCH 1/1 fs: btrfs: fixes a pass by reference issue in send.c

This patch fixes a pointer issue from passing a struct as a parameter to the function btrfs_root_dec_send_in_progress.

---
 fs/btrfs/send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/send.c +1 -1
index 63a6152..47ee63e 100644
@@ -5911,7 +5911,7 @@ commit_trans:
 	return btrfs_commit_transaction(trans, sctx->send_root);
 }
 
-static void btrfs_root_dec_send_in_progress(struct btrfs_root* root)
+static void btrfs_root_dec_send_in_progress(struct btrfs_root *root)
 {
 	spin_lock(&root->root_item_lock);
 	root->send_in_progress--;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 13 lines · Ben Marsh

This patch fixes a pointer issue from passing a struct as a parameter to the function btrfs_root_dec_send_in_progress.

---
 fs/btrfs/send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/send.c +0 -0
index 63a6152..47ee63e 100644

fs/btrfs/send.c commit_trans: · line 5914

Quoted 5 lines
fs/btrfs/send.c +1 -1
@@ -5911,7 +5911,7 @@ commit_trans:
        return btrfs_commit_transaction(trans, sctx->send_root);
 }
 
-static void btrfs_root_dec_send_in_progress(struct btrfs_root* root)
+static void btrfs_root_dec_send_in_progress(struct btrfs_root *root)

It's a white space change. Both forms are equivalent and pass the root by reference.
IOW, you aren't fixing any problem.

Quoted 10 lines
fs/btrfs/send.c +0 -1
 {
        spin_lock(&root->root_item_lock);
        root->send_in_progress--;
--

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 5 lines
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."