gpio: add TS-4800 fpga GPIO support

Hello Julien Grossholtz,

The patch 5041e791440a: "gpio: add TS-4800 fpga GPIO support" from Jan 13, 2016, leads to the following static checker warning:

	drivers/gpio/gpio-ts4800.c:52 ts4800_gpio_probe()
	warn: odd binop '0x1 & 0x8'

drivers/gpio/gpio-ts4800.c

    43          retval = of_property_read_u32(node, "ngpios", &ngpios);
    44          if (retval == -EINVAL)
    45                  ngpios = DEFAULT_PIN_NUMBER;
    46          else if (retval)
    47                  return retval;
    48  
    49          retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
    50                              base_addr + OUTPUT_REG_OFFSET, NULL,
    51                              base_addr + DIRECTION_REG_OFFSET, NULL,
    52                              BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);

Probably | was intended instead of &.

    53          if (retval) {
    54                  dev_err(&pdev->dev, "bgpio_init failed\n");
    55                  return retval;
    56          }
    57  

regards,
dan carpenter

Hello Dan,

Thank you for pointing that out. It made me figure out there is no need for any of those flags for this driver.

I will send a fix for this soon.

Julien Grossholtz

----- Original Message -----
From: "Dan Carpenter" <[email protected]>
To: "julien grossholtz" <[email protected]>
Cc: [email protected]
Sent: Tuesday, February 9, 2016 2:26:46 PM
Subject: re: gpio: add TS-4800 fpga GPIO support

Hello Julien Grossholtz,

The patch 5041e791440a: "gpio: add TS-4800 fpga GPIO support" from Jan 13, 2016, leads to the following static checker warning:

	drivers/gpio/gpio-ts4800.c:52 ts4800_gpio_probe()
	warn: odd binop '0x1 & 0x8'

drivers/gpio/gpio-ts4800.c

    43          retval = of_property_read_u32(node, "ngpios", &ngpios);
    44          if (retval == -EINVAL)
    45                  ngpios = DEFAULT_PIN_NUMBER;
    46          else if (retval)
    47                  return retval;
    48  
    49          retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
    50                              base_addr + OUTPUT_REG_OFFSET, NULL,
    51                              base_addr + DIRECTION_REG_OFFSET, NULL,
    52                              BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);

Probably | was intended instead of &.

    53          if (retval) {
    54                  dev_err(&pdev->dev, "bgpio_init failed\n");
    55                  return retval;
    56          }
    57  

regards,
dan carpenter