Skip to contentSkip to conversation

staging: rtl8188eu: add release_firmware() between request_firmware and function error exit

PATCH New Ivan Safonov 1 participant 1 message Feb 11, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 staging: rtl8188eu: add release_firmware() between request_firmware and function error exit

Small memory leak fixed.

---
 drivers/staging/rtl8188eu/hal/fw.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/fw.c +4 -1
index 55c17df..656133c 100644
@@ -175,14 +175,17 @@ int rtl88eu_download_fw(struct adapter *adapt)
 	if (fw->size > FW_8188E_SIZE) {
 		dev_err(device, "Firmware size exceed 0x%X. Check it.\n",
 			FW_8188E_SIZE);
+		release_firmware(fw);
 		return -1;
 	}
 
 	trailing_zeros_length = (4 - fw->size % 4) % 4;
 
 	fw_data = kmalloc(fw->size + trailing_zeros_length, GFP_KERNEL);
-	if (!fw_data)
+	if (!fw_data) {
+		release_firmware(fw);
 		return -ENOMEM;
+	}
 
 	memcpy(fw_data, fw->data, fw->size);
 	memset(fw_data + fw->size, 0, trailing_zeros_length);
Signature · 1 line
2.4.10