staging: lustre/lnet: Fix wrong typecasting warning generated by sparse
PATCH 1/1 staging: lustre/lnet: Fix wrong typecasting warning generated by sparse
Fix the following warning generated about type casting by sparse
warning: cast removes address space of expression
The current implementation casts the structure pointers with (char *) without __user annotation and then adds sizeof struct to it, thereby generating the sparse warning. Fixed this by removing the unnecessary char pointer type cast.
Signed-off-by Niranjan Dighe <[email protected]>
--- drivers/staging/lustre/lnet/selftest/console.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/lustre/lnet/selftest/console.c +2 -4
@@ -1460,10 +1460,8 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg,return 0 ; sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0 ]; - srpc_stat = (srpc_counters_t __user *) - ((char *)sfwk_stat +sizeof (*sfwk_stat)); - lnet_stat = (lnet_counters_t __user *) - ((char *)srpc_stat +sizeof (*srpc_stat)); + srpc_stat = (srpc_counters_t __user *)(sfwk_stat +1 ); + lnet_stat = (lnet_counters_t __user *)(srpc_stat +1 ); if (copy_to_user(sfwk_stat, &rep->str_fw, sizeof(*sfwk_stat)) || copy_to_user(srpc_stat, &rep->str_rpc, sizeof(*srpc_stat)) ||
Signature · 1 line
1.9.1