staging: netlogic: Fix parenthesis alignment
PATCH 1/1 staging: netlogic: Fix parenthesis alignment
Parameter lines are aligned with the open parenthesis. Checkpatch found this issue.
Signed-off-by Laura Garcia Liebana <[email protected]>
--- drivers/staging/netlogic/platform_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/netlogic/platform_net.c +2 -2
@@ -122,8 +122,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr) ndata1.phy_addr[mac] = mac +4 +0x10 ;xlr_resource_init (&xlr_net1_res[mac *2 ], - xlr_gmac_offsets[mac +4 ], - xlr_gmac_irqs[mac +4 ]); + xlr_gmac_offsets[mac +4 ], + xlr_gmac_irqs[mac +4 ]); } xlr_net_dev1.num_resources =8 ;
Signature · 1 line
2.7.0
Quoted 2 lines · Laura Garcia Liebana
Parameter lines are aligned with the open parenthesis. Checkpatch found this issue.
The commit message is ambiguous. They are aligned in the sense that that is how they were, or in the sense that that is what you have changed them into. It is better to write the commit message in the imperative, as that makes it more clear what is done, and also tends to lead to messages that are concise. So you could say "Align arguments with the open parenthesis".
julia
Quoted 31 lines
Signed-off-by Laura Garcia Liebana <[email protected]>--- drivers/staging/netlogic/platform_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/netlogic/platform_net.c +2
-2@@ -122,8 +122,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr) ndata1.phy_addr[mac] = mac +4 +0x10 ;xlr_resource_init (&xlr_net1_res[mac *2 ], - xlr_gmac_offsets[mac +4 ], - xlr_gmac_irqs[mac +4 ]); + xlr_gmac_offsets[mac +4 ], + xlr_gmac_irqs[mac +4 ]); } xlr_net_dev1.num_resources =8 ;Signature · 8 lines
2.7.0 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160214152440.GA27776%40sonyv. For more options, visit https://groups.google.com/d/optout.