Skip to contentSkip to conversation

Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

PATCH In review Sandhya 3 participants 3 messages Feb 19, 2016 – Feb 20, 2016 TTY layer and serial drivers

lore
Share & tools
lore

Sandhya

author
#0 lore raw

PATCH 1/1 Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

Add space before open parenthesis of "if" statement and fix indent warning. The checkpatch.pl script reported error and warning.

drivers/tty/amiserial.c +4 -4
index 2caaf5a..9a5c584 100644
@@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
 	custom.intreq = IF_RBF;
 	mb();
 
-	if((serdatr & 0x1ff) == 0)
-	    status |= UART_LSR_BI;
-	if(serdatr & SDR_OVRUN)
-	    status |= UART_LSR_OE;
+	if ((serdatr & 0x1ff) == 0)
+		status |= UART_LSR_BI;
+	if (serdatr & SDR_OVRUN)
+		status |= UART_LSR_OE;
 
 	ch = serdatr & 0xff;
 	icount->rx++;
maintainer
#1 lore raw
Quoted 13 lines · Sandhya

Add space before open parenthesis of "if" statement and fix indent warning. The checkpatch.pl script reported error and warning.

drivers/tty/amiserial.c +0 -1
index 2caaf5a..9a5c584 100644
@@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
 	custom.intreq = IF_RBF;
 	mb();
 
-	if((serdatr & 0x1ff) == 0)

drivers/tty/amiserial.c static void receive_chars(struct serial_state *info) · line 271

Quoted 10 lines
drivers/tty/amiserial.c +4 -3
-	    status |= UART_LSR_BI;
-	if(serdatr & SDR_OVRUN)
-	    status |= UART_LSR_OE;
+	if ((serdatr & 0x1ff) == 0)
+		status |= UART_LSR_BI;
+	if (serdatr & SDR_OVRUN)
+		status |= UART_LSR_OE;
 
 	ch = serdatr & 0xff;
 	icount->rx++;

We can't accept Outreachy application patches outside of the drivers/staging/ portion of the kernel, sorry.

Also you forgot a signed-off-by: line, please go read the tutorial again for all of the proper steps needed to create a patch.

thanks,

greg k-h

#2 lore raw
In reply to Sandhya

You need a Signed-off-by line with your full name, and that should match the From line of your patch, which here seems t contain only your first name.

julia

Quoted 30 lines · Sandhya

Add space before open parenthesis of "if" statement and fix indent warning. The checkpatch.pl script reported error and warning.

drivers/tty/amiserial.c +4 -5
index 2caaf5a..9a5c584 100644
@@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
 	custom.intreq = IF_RBF;
 	mb();
 
-	if((serdatr & 0x1ff) == 0)
-	    status |= UART_LSR_BI;
-	if(serdatr & SDR_OVRUN)
-	    status |= UART_LSR_OE;
+	if ((serdatr & 0x1ff) == 0)
+		status |= UART_LSR_BI;
+	if (serdatr & SDR_OVRUN)
+		status |= UART_LSR_OE;
 
 	ch = serdatr & 0xff;
 	icount->rx++;
 
--

You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160219120741.GA5755%40sandhya.
For more options, visit https://groups.google.com/d/optout.