Staging: sm750fb: Remove trailing whitespace.

PATCH Superseded Sandhya Bankar 2 participants 3 messages Feb 22, 2016 – Feb 23, 2016

Subsystems (2)

Staging Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Sandhya Bankar

author

2016-02-22 18:10 UTC #0 lore raw

PATCH 1/1 Staging: sm750fb: Remove trailing whitespace.

Remove trailing whitespace.This error is detected by checkpatch.pl script.

Signed-off-by Sandhya Bankar <[email protected]>

---
 drivers/staging/sm750fb/ddk750_power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/sm750fb/ddk750_power.c +2 -2

index 33e092e..f34b15d 100644
@@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
 	u32 gate;
 
 	gate = PEEK32(CURRENT_GATE);
-	if (enable) 
+	if (enable)
 		gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
-	 else 
+	 else
 		gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
 
 	setCurrentGate(gate);

Signature · 1 line

1.8.3.4

Julia Lawall

2016-02-23 15:55 UTC #1 lore raw

Quoted 12 lines · Sandhya Bankar

Remove trailing whitespace.This error is detected by checkpatch.pl script.
Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/sm750fb/ddk750_power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_power.c +0 -0
index 33e092e..f34b15d 100644

drivers/staging/sm750fb/ddk750_power.c void enable2DEngine(unsigned int enable) · line 111

Quoted 8 lines

drivers/staging/sm750fb/ddk750_power.c +2 -2

@@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
 	u32 gate;
 
 	gate = PEEK32(CURRENT_GATE);
-	if (enable) 
+	if (enable)
 		gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
-	 else 
+	 else

There is also an unneeded space in front of the else. Maybe you could fix up all of the whitespace problems in this if at once.

julia

Quoted 13 lines

drivers/staging/sm750fb/ddk750_power.c +0 -0

 		gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
 
 	setCurrentGate(gate);

Signature · 8 lines

1.8.3.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160222100856.GA5026%40sandhya.
For more options, visit https://groups.google.com/d/optout.

sandhya bankar

author

2016-02-23 17:47 UTC #2 lore raw

hello,
thanks for suggestions..i will resend patch v2..

Thanks
sandhya bankar

Quoted 50 lines · Julia Lawall

Quoted 1 line · Sandhya Bankar
Remove trailing whitespace.This error is detected by checkpatch.pl
script.
Review
Quoted 7 lines
Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/sm750fb/ddk750_power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/staging/sm750fb/ddk750_power.c
drivers/staging/sm750fb/ddk750_power.c void enable2DEngine(unsigned int enable) · line 111
Quoted 12 lines
index 33e092e..f34b15d 100644
drivers/staging/sm750fb/ddk750_power.c +2 -2
@@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
      u32 gate;
 
      gate = PEEK32(CURRENT_GATE);
-     if (enable)
+     if (enable)
              gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
-      else
+      else
There is also an unneeded space in front of the else. Maybe you could fix up all of the whitespace problems in this if at once.
julia
Quoted 8 lines
drivers/staging/sm750fb/ddk750_power.c +0 -1
              gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
 
      setCurrentGate(gate);
--
1.8.3.4
--
You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20160222100856.GA5026%40sandhya
.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.