Skip to contentSkip to conversation

fpga manager: Add hardware dependency to Zynq driver

PATCH Superseded Jean Delvare 3 participants 3 messages Feb 22, 2016 FPGA manager framework

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga manager: Add hardware dependency to Zynq driver

The Zynq FPGA manager driver serves no purpose on other architectures so hide it unless build-testing.

Cc Alan Tull <[email protected]>
Cc Moritz Fischer <[email protected]>
Cc Michal Simek <[email protected]>
Cc "Sören Brinkmann" <[email protected]>

---
Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?

 drivers/fpga/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on ARCH_ZYNQ || COMPILE_TEST
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw
Quoted 17 lines · Jean Delvare

The Zynq FPGA manager driver serves no purpose on other architectures so hide it unless build-testing.

Cc Alan Tull <[email protected]>
Cc Moritz Fischer <[email protected]>
Cc Michal Simek <[email protected]>
Cc "Sören Brinkmann" <[email protected]>

---
Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?

 drivers/fpga/Kconfig |    1 +
 1 file changed, 1 insertion(+)

drivers/fpga/Kconfig config FPGA_MGR_SOCFPGA · line 27

Quoted 7 lines
drivers/fpga/Kconfig +1 -0
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on ARCH_ZYNQ || COMPILE_TEST
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 

This driver is zynq specific. ZynqMP will have different driver. I have no problem to limit this driver just for Zynq. Currently I am not aware about other usage without changes in the driver.

Thanks,
Michal

#2 lore raw

Hi Jean,

Quoted 9 lines · Michal Simek
Quoted 8 lines · Jean Delvare

The Zynq FPGA manager driver serves no purpose on other architectures so hide it unless build-testing.

Cc Alan Tull <[email protected]>
Cc Moritz Fischer <[email protected]>
Cc Michal Simek <[email protected]>
Cc "Sören Brinkmann" <[email protected]>

Thanks for catching that,

Moritz