staging: gdm72xx: underflow in netlink_rcv_cb()

PATCH New Dan Carpenter 1 participant 1 message Feb 22, 2016

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-02-22 19:30 UTC #0 lore raw

PATCH 1/6 staging: gdm72xx: underflow in netlink_rcv_cb()

If nlh->nlmsg_len is less than ND_IFINDEX_LEN we end up trying to memcpy a negative size. I also re-ordered slighty the condition to make it more uniform.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/gdm72xx/netlink_k.c +2 -1

index cf0b47c..4089b17 100644
@@ -55,7 +55,8 @@ static void netlink_rcv_cb(struct sk_buff *skb)
 	if (skb->len >= NLMSG_HDRLEN) {
 		nlh = (struct nlmsghdr *)skb->data;
 
-		if (skb->len < nlh->nlmsg_len ||
+		if (nlh->nlmsg_len < ND_IFINDEX_LEN ||
+		    nlh->nlmsg_len > skb->len ||
 		    nlh->nlmsg_len > ND_MAX_MSG_LEN) {
 			netdev_err(skb->dev, "Invalid length (%d,%d)\n",
 				   skb->len, nlh->nlmsg_len);