Skip to contentSkip to conversation

ARC: leftover reference on ARC_IPI_DBG

DISCUSSION Valentin Rothberg 2 participants 2 messages Feb 24, 2016

lore
Share & tools
lore
#0 lore raw

Hi Vineet,

your commit 0443ad7fb2eb ("ARC: SMP: No need for CONFIG_ARC_IPI_DBG") has shown up in todays linux-next tree (i.e., next-20160224) and removes the Kconfig option ARC_IPI_DBG and all referencing #ifdefs but one:

arch/arc/kernel/mcip.c:58:#ifdef CONFIG_ARC_IPI_DBG
arch/arc/kernel/mcip.c-59- if (ipi_was_pending)
arch/arc/kernel/mcip.c-60- pr_info("IPI ACK delayed from cpu %d\n", cpu);
arch/arc/kernel/mcip.c-61-#endif arch/arc/kernel/mcip.c-62-}

If you want to, I can send a trivial patch removing either the entire block or just the CPP macros.

I detected the issue with scripts/checkkconfigsymbols.py by diffing yesterdays and todays next tree.

Best regards,
Valentin

#1 lore raw

Hi Valentin,

Quoted 12 lines · Valentin Rothberg

Hi Vineet,

your commit 0443ad7fb2eb ("ARC: SMP: No need for CONFIG_ARC_IPI_DBG") has shown up in todays linux-next tree (i.e., next-20160224) and removes the Kconfig option ARC_IPI_DBG and all referencing #ifdefs but one:

arch/arc/kernel/mcip.c:58:#ifdef CONFIG_ARC_IPI_DBG
arch/arc/kernel/mcip.c-59- if (ipi_was_pending)
arch/arc/kernel/mcip.c-60- pr_info("IPI ACK delayed from cpu %d\n", cpu);
arch/arc/kernel/mcip.c-61-#endif arch/arc/kernel/mcip.c-62-}

Quoted 5 lines

If you want to, I can send a trivial patch removing either the entire block or just the CPP macros.

I detected the issue with scripts/checkkconfigsymbols.py by diffing yesterdays and todays next tree.

Thx for catching this - I had done a git grep after initial fix, but didn't after the rebasing/reordering of patches
Please do send the patch which removes this hunk altogether !

Thx
-Vineet

Quoted 4 lines

Best regards,
Valentin