Still many meta-networking changes waiting in patchwork/master-next
Hi Joe.
there are still 18 meta-networking commits in master-next:
pick 959b908 postfix: premission of /var/spool/mail seems incorrect pick 21ccb84 wireshark: update SRC_URI link to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enable KERNEL_64_USERSPACE_32 for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabled
Not all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=both
postfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie New
If they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Hey Martin,
Quoted 3 lines · [[oe] Still many meta-networking changes waiting in patchwork/master-next] On…
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
-J.
Quoted 49 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=bothpostfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie NewIf they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Signature · 2 lines
-Joe MacDonald. :wq
Quoted 13 lines · Joe MacDonald
Hey Martin,
Quoted 3 lines · [[oe] Still many meta-networking changes waiting in patchwork/master-next] On…
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
Quoted 58 lines
-J.
Quoted 49 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=bothpostfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie NewIf they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]Signature · 2 lines
-Joe MacDonald. :wq
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Hi Martin,
Quoted 19 lines · [Re: [oe] Still many meta-networking changes waiting in patchwork/master-next]…
Quoted 13 lines · Joe MacDonald
Hey Martin,
Quoted 3 lines · [[oe] Still many meta-networking changes waiting in patchwork/master-next] On…
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \
oe/master-next...oe/master meta-networking | \
xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \
oe/master-next...oe/master meta-networking | \
xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \
oe/master-next...oe/master meta-networking | \
xargs -r -n1 pwclient search -f "%{name}" -s new | \
sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \
xargs -r -n1 git log --format="%h" --grep | \
xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \
master...oe/master meta-networking | \
xargs -r -n1 pwclient search -f "%{id}" -s new | \
xargs -r -n1 pwclient update -s "accepted" There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
-J.
Quoted 62 lines
Quoted 59 lines
-J.
Quoted 49 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=bothpostfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie NewIf they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]Signature · 2 lines
-Joe MacDonald. :wq
Signature · 2 lines
-Joe MacDonald. :wq
Quoted 103 lines · Joe MacDonald
Hi Martin,
Quoted 19 lines · [Re: [oe] Still many meta-networking changes waiting in patchwork/master-next]…
Quoted 13 lines · Joe MacDonald
Hey Martin,
Quoted 3 lines · [[oe] Still many meta-networking changes waiting in patchwork/master-next] On…
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Quoted 6 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
After bigger merge yesterday I have only the waf-samba change in master-next (and few new changes), can you please update status of few pending changes in meta-networking bundle?
http://patchwork.openembedded.org/bundle/jama/meta-networking/?archive=both
There is 22 changes and most of them were probably already merged or rejected.
Quoted 68 lines
-J.
Quoted 62 lines
Quoted 59 lines
-J.
Quoted 49 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=bothpostfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie NewIf they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]Signature · 2 lines
-Joe MacDonald. :wqSignature · 2 lines
-Joe MacDonald. :wq
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 111 lines · [Re: [oe] Still many meta-networking changes waiting in patchwork/master-next]…
Quoted 103 lines · Joe MacDonald
Hi Martin,
Quoted 19 lines · [Re: [oe] Still many meta-networking changes waiting in patchwork/master-next]…
Quoted 13 lines · Joe MacDonald
Hey Martin,
Quoted 3 lines · [[oe] Still many meta-networking changes waiting in patchwork/master-next] On…
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Quoted 6 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
Quoted 2 lines
After bigger merge yesterday I have only the waf-samba change in master-next (and few new changes),
Yeah, the waf-samba change has been deliberately left to the end since Jackie's waf-samba commits are now considerably out of date and touch more than just meta-networking, so I'm trying to be extra careful with them.
Quoted 3 lines
can you please update status of few pending changes in meta-networking bundle?
http://patchwork.openembedded.org/bundle/jama/meta-networking/?archive=both
Sure thing.
Quoted 74 lines
There is 22 changes and most of them were probably already merged or rejected.
Quoted 68 lines
-J.
Quoted 62 lines
Quoted 59 lines
-J.
Quoted 49 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=bothpostfix: premission of /var/spool/mail seems incorrect 2015-10-27 Zhenbo Gao New [meta-oe] lldpd: configure the systemd unit file dir 2015-10-30 [email protected] New [meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens Rehsack New [meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 Jens Rehsack New [2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert Yang New [6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert Yang New [7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackie huang New [2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang New ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22 [email protected] New [meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by qemu 2016-01-06 jackie huang New [meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-01-06 jackie huang New ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20 [email protected] New [RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollister New [07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie NewIf they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]Signature · 2 lines
-Joe MacDonald. :wqSignature · 2 lines
-Joe MacDonald. :wq
Signature · 2 lines
-Joe MacDonald. :wq
Quoted 1 line · On Wed, 02 Mar 2016 08:27:26 Joe MacDonald wrote:
[Re: [oe] Still many meta-networking changes waiting in patchwork/master-
Quoted 4 lines · next] On 16.03.02 (Wed 11:33) Martin Jansa wrote:
Quoted 4 lines · Joe MacDonald
Quoted 3 lines
Hi Martin,
[Re: [oe] Still many meta-networking changes waiting in
Quoted 4 lines · patchwork/master-next] On 16.02.26 (Fri 20:56) Martin Jansa wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines · Joe MacDonald
Quoted 3 lines
Hey Martin,
[[oe] Still many meta-networking changes waiting in
Quoted 125 lines · patchwork/master-next] On 16.02.25 (Thu 18:19) Martin Jansa wrote:
Quoted 120 lines
Quoted 111 lines
Quoted 18 lines
Quoted 10 lines
Quoted 3 lines
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with
these before the end of the month. Almost all of them (waf-samba aside)
obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.Quoted 7 lines
I think I've asked before, but are you curating all of those bundles by
hand or have you got some machinery that filters patches into bundles
based on path names in the patches? Because that would be kind of neat
to have.Quoted 6 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them
"Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.Yeah, I've seen the hooks trying to find something when I push commits and
just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.Quoted 6 lines
This is of course a bit error prone, especially when there are multiple
versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older
versions already as Superseded when filtering incoming queue).I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better
way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work
around that pretty rare (I hope) corner case. As an aside, the first time
I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.So that gave me 14 of the patches you asked about. The others were easy
to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient
output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.Run it a second time to grab the three 'accepted' patches and we're nearly
done.Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping
patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git
hooks are non-functional.The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that
I don't think could ever be caught except by manual intervention.Quoted 8 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell
function or git alias yet, at least my process is archived in the mailing
list and I can find it again if I need it.Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
Quoted 5 lines
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
FWIW, and I know some people may be tired of hearing about this without much visible progress, but we still have some people within Intel working on Patchwork as well as some automated patch testing functionality aimed at OE specifically, and they are making progress. I hope to have something to show pretty soon. It should eliminate a lot of the manual work required with the current version.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 137 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Joe MacDonald
Sent: Wednesday, March 02, 2016 9:27 PM
To: Martin Jansa
Cc: [email protected]
Subject: Re: [oe] Still many meta-networking changes waiting in patchwork/master-next[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.03.02 (Wed
Quoted 4 lines · 11:33) Martin Jansa wrote:
Quoted 3 lines · Joe MacDonald
Hi Martin,
[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.26 (Fri
Quoted 5 lines · 20:56) Martin Jansa wrote:
Quoted 5 lines
Quoted 5 lines · Joe MacDonald
Quoted 3 lines
Hey Martin,
[[oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.25 (Thu
Quoted 102 lines · 18:19) Martin Jansa wrote:
Quoted 95 lines
Quoted 15 lines
Quoted 10 lines
Quoted 4 lines
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Quoted 6 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
Quoted 5 lines
Quoted 2 lines
After bigger merge yesterday I have only the waf-samba change in master-next (and few new changes),
Yeah, the waf-samba change has been deliberately left to the end since Jackie's waf-samba commits are now considerably out of date and touch
When I made those patches, samba and related recipes were in meta-oe, then they were moved to meta-networking and I rebased them twice after that, but the patch for waf-samba.bbclass is still applied for meta-oe. Do you think we need to move it to meta-networking as well?
Thanks,
Jackie
Quoted 100 lines
more than just meta-networking, so I'm trying to be extra careful with them.
Quoted 3 lines
can you please update status of few pending changes in meta-networking bundle?
http://patchwork.openembedded.org/bundle/jama/meta-networking/?archive=bothSure thing.
Quoted 35 lines
There is 22 changes and most of them were probably already merged or rejected.
Quoted 32 lines
-J.
Quoted 29 lines
Quoted 29 lines
-J.
Quoted 25 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=both
postfix: premission of/var/spool/mailseems incorrect 2015-10-27 Zhenbo GaoNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] lldpd: configure the systemd unit file dir 2015-10-30
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens
Rehsack New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 JensRehsack New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert YangNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert YangNew
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackiehuang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang
New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by
qemu 2016-01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-
01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollisterNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie
New
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 14 lines
Quoted 8 lines
If they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
--
Martin 'JaMa' Jansa jabber: [email protected]--
-Joe MacDonald.
:wqQuoted 6 lines
Quoted 3 lines
--
-Joe MacDonald.
:wq--
-Joe MacDonald.
:wq
Quoted 144 lines · [Re: [oe] Still many meta-networking changes waiting in patchwork/master-next]…
Quoted 1 line · On Wed, 02 Mar 2016 08:27:26 Joe MacDonald wrote:
[Re: [oe] Still many meta-networking changes waiting in patchwork/master-
Quoted 4 lines · next] On 16.03.02 (Wed 11:33) Martin Jansa wrote:
Quoted 4 lines · Joe MacDonald
Quoted 3 lines
Hi Martin,
[Re: [oe] Still many meta-networking changes waiting in
Quoted 4 lines · patchwork/master-next] On 16.02.26 (Fri 20:56) Martin Jansa wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines · Joe MacDonald
Quoted 3 lines
Hey Martin,
[[oe] Still many meta-networking changes waiting in
Quoted 125 lines · patchwork/master-next] On 16.02.25 (Thu 18:19) Martin Jansa wrote:
Quoted 120 lines
Quoted 111 lines
Quoted 18 lines
Quoted 10 lines
Quoted 3 lines
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with
these before the end of the month. Almost all of them (waf-samba aside)
obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.Quoted 7 lines
I think I've asked before, but are you curating all of those bundles by
hand or have you got some machinery that filters patches into bundles
based on path names in the patches? Because that would be kind of neat
to have.Quoted 6 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them
"Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.Yeah, I've seen the hooks trying to find something when I push commits and
just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.Quoted 6 lines
This is of course a bit error prone, especially when there are multiple
versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older
versions already as Superseded when filtering incoming queue).I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better
way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work
around that pretty rare (I hope) corner case. As an aside, the first time
I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.So that gave me 14 of the patches you asked about. The others were easy
to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient
output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.Run it a second time to grab the three 'accepted' patches and we're nearly
done.Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping
patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git
hooks are non-functional.The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that
I don't think could ever be caught except by manual intervention.Quoted 8 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell
function or git alias yet, at least my process is archived in the mailing
list and I can find it again if I need it.Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
Quoted 5 lines
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
Quoted 6 lines
FWIW, and I know some people may be tired of hearing about this without much visible progress, but we still have some people within Intel working on Patchwork as well as some automated patch testing functionality aimed at OE specifically, and they are making progress. I hope to have something to show pretty soon. It should eliminate a lot of the manual work required with the current version.
I was wondering about that. I'm quite looking forward to it. At the very least I know newer versions of patchwork than the one we have right now offer an improved bundle experience.
Signature · 2 lines
-Joe MacDonald. :wq
Quoted 140 lines · Jie (Jackie)
Quoted 140 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Joe MacDonald
Sent: Wednesday, March 02, 2016 9:27 PM
To: Martin Jansa
Cc: [email protected]
Subject: Re: [oe] Still many meta-networking changes waiting in patchwork/master-next[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.03.02 (Wed
Quoted 4 lines · 11:33) Martin Jansa wrote:
Quoted 3 lines · Joe MacDonald
Hi Martin,
[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.26 (Fri
Quoted 5 lines · 20:56) Martin Jansa wrote:
Quoted 5 lines
Quoted 5 lines · Joe MacDonald
Quoted 3 lines
Hey Martin,
[[oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.25 (Thu
Quoted 102 lines · 18:19) Martin Jansa wrote:
Quoted 95 lines
Quoted 15 lines
Quoted 10 lines
Quoted 4 lines
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Quoted 6 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
Quoted 2 lines
After bigger merge yesterday I have only the waf-samba change in master-next (and few new changes),
Quoted 7 lines
Quoted 2 lines
Yeah, the waf-samba change has been deliberately left to the end since Jackie's waf-samba commits are now considerably out of date and touch
When I made those patches, samba and related recipes were in meta-oe, then they were moved to meta-networking and I rebased them twice after that, but the patch for waf-samba.bbclass is still applied for meta-oe. Do you think we need to move it to meta-networking as well?
I wouldn't object to such a move. I don't think it'll impact anyone outside of meta-networking.
-J.
Quoted 104 lines
Thanks,
JackieQuoted 100 lines
more than just meta-networking, so I'm trying to be extra careful with them.
Quoted 3 lines
can you please update status of few pending changes in meta-networking bundle?
http://patchwork.openembedded.org/bundle/jama/meta-networking/?archive=bothSure thing.
Quoted 35 lines
There is 22 changes and most of them were probably already merged or rejected.
Quoted 32 lines
-J.
Quoted 29 lines
Quoted 29 lines
-J.
Quoted 25 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-next here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=both
postfix: premission of/var/spool/mailseems incorrect 2015-10-27 Zhenbo GaoNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] lldpd: configure the systemd unit file dir 2015-10-30
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens
Rehsack New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 JensRehsack New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert YangNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert YangNew
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackiehuang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang
New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by
qemu 2016-01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-
01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollisterNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie
New
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 14 lines
Quoted 8 lines
If they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
--
Martin 'JaMa' Jansa jabber: [email protected]--
-Joe MacDonald.
:wqQuoted 6 lines
Quoted 3 lines
--
-Joe MacDonald.
:wq--
-Joe MacDonald.
:wq
Signature · 2 lines
-Joe MacDonald. :wq
Quoted 158 lines
-----Original Message-----
From: Joe MacDonald [mailto:[email protected]]
Sent: Friday, March 04, 2016 4:49 AM
To: Huang, Jie (Jackie)
Cc: Martin Jansa; [email protected]
Subject: Re: [oe] Still many meta-networking changes waiting in patchwork/master-next[RE: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.03.03 (Thu
Quoted 11 lines · Jie (Jackie)
Quoted 11 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Joe MacDonald
Sent: Wednesday, March 02, 2016 9:27 PM
To: Martin Jansa
Cc: [email protected]
Subject: Re: [oe] Still many meta-networking changes waiting in patchwork/master-next[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.03.02
(Wed
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines · 11:33) Martin Jansa wrote:
Quoted 3 lines · Joe MacDonald
Hi Martin,
[Re: [oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.26
(Fri
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines · 20:56) Martin Jansa wrote:
Quoted 5 lines
Quoted 5 lines · Joe MacDonald
Quoted 3 lines
Hey Martin,
[[oe] Still many meta-networking changes waiting in patchwork/master-next] On 16.02.25
(Thu
Quoted 120 lines
Quoted 119 lines
Quoted 102 lines · 18:19) Martin Jansa wrote:
Quoted 95 lines
Quoted 15 lines
Quoted 10 lines
Quoted 4 lines
Hi Joe.
there are still 18 meta-networking commits in master-next:
I thought I'd follow up to this and let you know I'll do something with these before the end of the month. Almost all of them (waf-samba aside) obviously got missed because I'm watching patchwork based on 'meta-networking' and none of these had it in the subject line.
Quoted 4 lines
I think I've asked before, but are you curating all of those bundles by hand or have you got some machinery that filters patches into bundles based on path names in the patches? Because that would be kind of neat to have.
Quoted 4 lines
I think I've answered before, but I'm filtering them manually based on subject and also actual paths inside the patch. I also need to mark them "Accepted", "Superseded", .. manually, there is git hooks which is supposed to mark at least accepted one, but it finds 1 from 1000 if any.
Yeah, I've seen the hooks trying to find something when I push commits and just spewing a slew of errors. I generally do my best to stay on top of the status in patchwork, doing it all at one time, though.
Quoted 4 lines
This is of course a bit error prone, especially when there are multiple versions of the same patch already in master-next - I usually end up marking all versions merged patch as Accepted (unless I've marked older versions already as Superseded when filtering incoming queue).
I took a bit of time this afternoon to try to come up with a way to automate at least part of the process for me and I'm sure there's a better way to do it (hence why I asked again) but since it sounds like you're doing it by hand for a much larger space than I am, maybe there's not.
Anyway, for what it's worth, here's what I came up with:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s NewWhich does pretty well, though it obviously goes a little insane if someone puts a ' in the short log, but it didn't seem worth trying to work around that pretty rare (I hope) corner case. As an aside, the first time I did this I was using --format="\"%s\"" and the *very* top commit ('recipes: Replace "cp ...) showed me what kind of pain I'm in for when there are colliding characters in the short log. It's ugly but nothing catastrophic.
So that gave me 14 of the patches you asked about. The others were easy to find:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id} %{name}" -s AcceptedBut obviously they haven't been accepted into 'master' next, obviously just a typo or a mis-click at some point. So that's not bad.
Once I had that sanity check done, it's easy to harvest them all:
git log --cherry-pick --format="'%s'" \ oe/master-next...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{name}" -s new | \ sed 's=\[.*\] *==;s="=.=g;s=\(.*\)="\1"=' | \ xargs -r -n1 git log --format="%h" --grep | \ xargs -r -n1 git cherry-pick -sThe hideous sed in the middle is just to throw out stuff from the pwclient output that doesn't appear in the git logs (eg. "[v2]") and to skip over the craziness that happens on the 'git log grep' if you have a " in the subject.
Run it a second time to grab the three 'accepted' patches and we're nearly done.
Setting aside all of the inspection steps that follow that nobody would want to automate, the same machinery applies equally well to keeping patchwork up to date:
git log --cherry-pick --format="'%s'" \ master...oe/master meta-networking | \ xargs -r -n1 pwclient search -f "%{id}" -s new | \ xargs -r -n1 pwclient update -s "accepted"There's not really any point in running this one a second time for the patches already marked 'accepted'.
I've been using a version of this last one for a while now because the git hooks are non-functional.
The end result is that my semi-automated process above gets 17 of the 18 patches you cited and the 18th (waf-samba.bbclass) is a special case that I don't think could ever be caught except by manual intervention.
Quoted 6 lines
Mostly just throwing this out there so that maybe it'll help you or someone else with similar tasks and maybe someone can look at what I'm doing and point out obvious flaws / shortcomings / bear-traps / improvements. And also since I haven't bothered to put this into a shell function or git alias yet, at least my process is archived in the mailing list and I can find it again if I need it.
Quoted 4 lines
Thanks for trying to improve patchwork experience with bunch of scripts. Personally I would prefer to just use gerrit (that's why I gave up trying to work around patchwork issues with scripts and rather sort & apply the patches manually with just small help from pwclient).
I've never been a fan of gerrit, but I've only used it on a couple of projects, so I don't really have a lot of experience with it. Probably obviously, so long as the CLI experience isn't terrible and I can easily script around things that don't work well for me, I can work with almost anything.
Quoted 2 lines
After bigger merge yesterday I have only the waf-samba change in master-next (and few new changes),
Yeah, the waf-samba change has been deliberately left to the end since Jackie's waf-samba commits are now considerably out of date and touch
Quoted 7 lines
Quoted 4 lines
When I made those patches, samba and related recipes were in meta-oe, then they were moved to meta-networking and I rebased them twice after that, but the patch for waf-samba.bbclass is still applied for meta-oe. Do you think we need to move it to meta-networking as well?
I wouldn't object to such a move. I don't think it'll impact anyone outside of meta-networking.
Ok, so I will move it to meta-networking, rebase my patch and re-send as follow-up.
Thanks,
Jackie
Quoted 112 lines
-J.
Quoted 45 lines
Thanks,
JackieQuoted 41 lines
more than just meta-networking, so I'm trying to be extra careful with them.
Quoted 3 lines
can you please update status of few pending changes in meta-networking bundle?
http://patchwork.openembedded.org/bundle/jama/meta-networking/?archive=bothSure thing.
Quoted 32 lines
There is 22 changes and most of them were probably already merged or rejected.
Quoted 29 lines
-J.
Quoted 26 lines
Quoted 26 lines
-J.
Quoted 22 lines
pick 959b908 postfix: premission of
/var/spool/mailseems incorrect pick 21ccb84 wireshark: updateSRC_URIlink to sources
pick 204683a nbd: use BPN in Files
pick ed0b197 cim-schema-exper: fix host-user-contaminated pick 1dd195e ctdb: add PACKAGECONFIG for libtdb
pick 3c95127 netkit-ftp: fixed invalid symlink
pick 56c4f31 iscsitarget: split the kernel module into separate package pick 38fd81c iscsitarget: skip the arch test for kernel modules pick 84bfeae ncftp: fix build failures with ccdv
pick 46b1e93 postfix: fix clean broken issue
pick ba57020 lowpan-tools: add missing flex/bison deps
pick dd64a6b samba: Fix typo in PACKAGECONFIG for "acl" and "aio" pick c3c6106 waf-samba.bbclass: add cross-answers option and files pick ef42784 ebtables: enableKERNEL_64_USERSPACE_32for powerpc pick 87edda7 samba: update systemd service files
pick 8b320f4 lldpd: use bash-completion.bbclass
pick 32b5c6f ntp: remove empty libexecdir to prevent potential QA issues pick 93c8a3c inetutils: Fix build when static libs disabledNot all of them are still "open" on patchwork, maybe they are no longer valid.
+ there are few meta-networking patches on patchwork which didn't make it to master-
next
Quoted 56 lines
Quoted 56 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
here is complete list:
http://patchwork.openembedded.org/bundle/jama/master-next/?archive=both
postfix: premission of/var/spool/mailseems incorrect 2015-10-27 Zhenbo GaoNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] lldpd: configure the systemd unit file dir 2015-10-30
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe] samba: systemv-init script must be executable 2015-11-04 Jens
Rehsack New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,v2,1/3] samba: fix dependencies and QA issues 2015-11-12 JensRehsack New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[2/7] nbd: use BPN in Files 2015-11-20 Robert Yang New [4/7] cim-schema-exper: fix host-user-contaminated 2015-11-20 Robert YangNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[6/7] ctdb: add PACKAGECONFIG for libtdb 2015-11-20 Robert YangNew
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[7/7] netkit-ftp: fixed invalid symlink 2015-11-20 Robert Yang New [1/2] iscsitarget: split the kernel module into separate package 2015-11-25 jackiehuang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[2/2] iscsitarget: skip the arch test for kernel modules 2015-11-25 jackie huang
New
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
ncftp: fix build failures with ccdv 2015-11-30 jackie huang New samba: Fix typo in PACKAGECONFIG for "acl" and "aio" 2015-12-22Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-networking,0/7,v3] waf-samba: fix build failure on targets unsupported by
qemu 2016-01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[meta-oe,7/7,v3] waf-samba.bbclass: add cross-answers option and files 2016-
01-06 jackie huang New
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
ebtables: enable KERNEL_64_USERSPACE_32 for powerpc 2016-01-20Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[RFC,3/4] lldpd: use bash-completion.bbclass 2016-01-14 George McCollisterNew
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[07/12] inetutils: Fix build when static libs disabled 2016-02-22 Richard Purdie
New
Quoted 23 lines
Quoted 20 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
If they are still there next month, I'll drop them from master-next branch and master-next bundle on patchwork.
Thanks
Quoted 11 lines
Quoted 8 lines
Quoted 2 lines
--
Martin 'JaMa' Jansa jabber: [email protected]--
-Joe MacDonald.
:wq--
-Joe MacDonald.
:wqQuoted 3 lines
Quoted 3 lines
--
-Joe MacDonald.
:wq--
-Joe MacDonald.
:wq