mailbox/xgene-slimpro: Checking for IS_ERR instead of NULL

PATCH New Dan Carpenter 1 participant 1 message Feb 25, 2016

Subsystems (2)

Kernel janitors Mailbox API

lore

Share & tools

lore

Dan Carpenter

author

2016-02-25 21:32 UTC #0 lore raw

PATCH 1/1 mailbox/xgene-slimpro: Checking for IS_ERR instead of NULL

devm_ioremap() returns NULL, it never returns an ERR_PTR.

Fixes f700e84f417b ('mailbox: Add support for APM X-Gene platform mailbox driver')

Signed-off-by Dan Carpenter <[email protected]>

drivers/mailbox/mailbox-xgene-slimpro.c +2 -2

index b5f5106..bd07f39 100644
@@ -196,8 +196,8 @@ static int slimpro_mbox_probe(struct platform_device *pdev)
 
 	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	mb_base = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
-	if (IS_ERR(mb_base))
-		return PTR_ERR(mb_base);
+	if (!mb_base)
+		return -ENOMEM;
 
 	/* Setup mailbox links */
 	for (i = 0; i < MBOX_CNT; i++) {