Skip to contentSkip to conversation

jffs2: Improve post-mount CRC scan efficiency

DISCUSSION Woodhouse, David 1 participant 1 message Feb 29, 2016 1 message not in the archive Memory technology devices (MTD)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20160229221715.GA5672@mwanda

#1 lore raw
Quoted 8 lines · Dan Carpenter

Hello David Woodhouse,

The patch d5e1e1d07f80: "jffs2: Improve post-mount CRC scan efficiency" from Feb 1, 2016, leads to the following static checker warning:

        fs/jffs2/gc.c:177 jffs2_garbage_collect_pass()
        error: double lock 'spin_lock:&c->inocache_lock'

Er, yeah. We're supposed to *unlock* it when we're finished, not lock it harder. Thanks :)

Signature · 2 lines
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation