What's wrong with my patch?
Hi,
I have sent a patch on 29 Feb, but no reply. I want to know what's wrong with my patch so that I can improve it and myself. my patch is like this:
Quoted 21 lines
Date: Mon, 29 Feb 2016 14:41:34 +0800
From: Navy Cheng <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: Lidza Louina <[email protected]>, kernelnewbies <[email protected]>
Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
User-Agent: Mutt/1.5.23 (2014-03-12)
pci_unregister_driver()should be used once dgnc module exit. It has nothing to do withdgnc_NumBoards. Remove the judgment ofdgnc_NumBoardsto avoidpci_unregister_driver()is not used whendgnc_NumBoardsis 0.Signed-off-by Navy Cheng <[email protected]>--- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/dgnc/dgnc_driver.c +0
-0
drivers/staging/dgnc/dgnc_driver.c static void dgnc_cleanup_module(void) · line 162
Quoted 9 lines
drivers/staging/dgnc/dgnc_driver.c +1
-2@@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)dgnc_tty_post_uninit (); -if (dgnc_NumBoards) -pci_unregister_driver (&dgnc_driver); +pci_unregister_driver (&dgnc_driver); }/*
Thank you :)
29 Feb is only one week old,
your patch is in queue, just wait.
2016-03-08 6:31 UTC+01:00, Navy Cheng <[email protected]>:
Quoted 46 lines
Hi,
I have sent a patch on 29 Feb, but no reply. I want to know what's wrong with my patch so that I can improve it and myself. my patch is like this:Quoted 24 lines
Date: Mon, 29 Feb 2016 14:41:34 +0800
From: Navy Cheng <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: Lidza Louina <[email protected]>, kernelnewbies <[email protected]>
Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
User-Agent: Mutt/1.5.23 (2014-03-12)
pci_unregister_driver()should be used once dgnc module exit. It has nothing to do withdgnc_NumBoards. Remove the judgment ofdgnc_NumBoardsto
avoidpci_unregister_driver()is not used whendgnc_NumBoardsis 0.Signed-off-by Navy Cheng <[email protected]>--- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/dgnc/dgnc_driver.c +0
-0drivers/staging/dgnc/dgnc_driver.c static void dgnc_cleanup_module(void) · line 162
Quoted 9 lines
drivers/staging/dgnc/dgnc_driver.c +1
-2@@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)dgnc_tty_post_uninit (); -if (dgnc_NumBoards) -pci_unregister_driver (&dgnc_driver); +pci_unregister_driver (&dgnc_driver); }/* Thank you :)
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Signature · 3 lines
? On ne r?sout pas un probl?me avec les modes de pens?e qui l?ont engendr?. ? ? You cannot solve current problems with current thinking. Current problems are the result of current thinking ?
Thank you for your reply :)
Quoted 61 lines
29 Feb is only one week old,
your patch is in queue, just wait.2016-03-08 6:31 UTC+01:00, Navy Cheng <[email protected]>:
Quoted 46 lines
Hi,
I have sent a patch on 29 Feb, but no reply. I want to know what's wrong with my patch so that I can improve it and myself. my patch is like this:Quoted 24 lines
Date: Mon, 29 Feb 2016 14:41:34 +0800
From: Navy Cheng <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: Lidza Louina <[email protected]>, kernelnewbies <[email protected]>
Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
User-Agent: Mutt/1.5.23 (2014-03-12)
pci_unregister_driver()should be used once dgnc module exit. It has nothing to do withdgnc_NumBoards. Remove the judgment ofdgnc_NumBoardsto
avoidpci_unregister_driver()is not used whendgnc_NumBoardsis 0.Signed-off-by Navy Cheng <[email protected]>--- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/dgnc/dgnc_driver.c +0
-0drivers/staging/dgnc/dgnc_driver.c static void dgnc_cleanup_module(void) · line 162
Quoted 9 lines
drivers/staging/dgnc/dgnc_driver.c +1
-2@@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)dgnc_tty_post_uninit (); -if (dgnc_NumBoards) -pci_unregister_driver (&dgnc_driver); +pci_unregister_driver (&dgnc_driver); }/* Thank you :)
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbiesSignature · 8 lines
? On ne r?sout pas un probl?me avec les modes de pens?e qui l?ont engendr?. ? ? You cannot solve current problems with current thinking. Current problems are the result of current thinking ? _______________________________________________ Kernelnewbies mailing list Kernelnewbies at kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies