Skip to contentSkip to conversation

Input: synaptics-rmi4 - add support for Synaptics RMI4 devices

DISCUSSION Dan Carpenter 1 participant 1 message Mar 14, 2016 HID

lore
Share & tools
lore
#0 lore raw

Hello Andrew Duggan,

The patch 2b6a321da9a2: "Input: synaptics-rmi4 - add support for Synaptics RMI4 devices" from Mar 10, 2016, leads to the following static checker warning:

	drivers/input/rmi4/rmi_driver.c:129 process_one_interrupt()
	warn: this array is probably non-NULL. 'fn->irq_mask'

drivers/input/rmi4/rmi_driver.c
120 static void process_one_interrupt(struct rmi_driver_data *data,
121 struct rmi_function *fn)
122 {
123 struct rmi_function_handler *fh;
124
125 if (!fn || !fn->dev.driver)
126 return;
127
128 fh = to_rmi_function_handler(fn->dev.driver);

   129          if (fn->irq_mask && fh->attention) {
                    ^^^^^^^^^^^^

Always true.

130 bitmap_and(data->fn_irq_bits, data->irq_status, fn->irq_mask,
131 data->irq_count);
132 if (!bitmap_empty(data->fn_irq_bits, data->irq_count))
133 fh->attention(fn, data->fn_irq_bits);
134 }
135 }

See also:
drivers/input/rmi4/rmi_driver.c:175 rmi_process_interrupt_requests() warn: this array is probably non-NULL. 'entry->irq_mask'

regards,
dan carpenter