m5mols: potential uninitialized variable

PATCH New Dan Carpenter 1 participant 1 message Mar 15, 2016

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-03-15 07:07 UTC #0 lore raw

PATCH 1/1 m5mols: potential uninitialized variable

Smatch complains that there are some paths where "status" isn't initialized. The code does assume that m5mols_read_u8() can fail so it seems as if Smatch is correct.

Let's initialize it to REG_ISO_AUTO which is zero.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/i2c/m5mols/m5mols_controls.c +1 -1

index a60931e..c2218c0 100644
@@ -405,7 +405,7 @@ static int m5mols_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
 	struct v4l2_subdev *sd = to_sd(ctrl);
 	struct m5mols_info *info = to_m5mols(sd);
 	int ret = 0;
-	u8 status;
+	u8 status = REG_ISO_AUTO;
 
 	v4l2_dbg(1, m5mols_debug, sd, "%s: ctrl: %s (%d)\n",
 		 __func__, ctrl->name, info->isp_ready);