thinkpad_acpi: silence an unintialized variable warning

PATCH New Dan Carpenter 1 participant 1 message Apr 15, 2016

Subsystems (2)

Kernel janitors x86 platform drivers

lore

Share & tools

lore

Dan Carpenter

author

2016-04-15 14:46 UTC #0 lore raw

PATCH 1/1 thinkpad_acpi: silence an unintialized variable warning

If fan_get_status() fails then "s" isn't initialized. I've tweaked the error handling a bit to silence this warning.

Signed-off-by Dan Carpenter <[email protected]>

drivers/platform/x86/thinkpad_acpi.c +3 -1

index e305ab5..9255ff3 100644
@@ -7972,10 +7972,12 @@ static int fan_get_status_safe(u8 *status)
 		fan_update_desired_level(s);
 	mutex_unlock(&fan_mutex);
 
+	if (rc)
+		return rc;
 	if (status)
 		*status = s;
 
-	return rc;
+	return 0;
 }
 
 static int fan_get_speed(unsigned int *speed)