Skip to contentSkip to conversation

Staging: dgnc: fix coding style in dgnc_tty.c

PATCH In review Patryk Mezydlo 2 participants 2 messages May 3, 2016 Staging

lore
Share & tools
lore

Patryk Mezydlo

author
#0 lore raw

PATCH 1/1 Staging: dgnc: fix coding style in dgnc_tty.c

Fix checkpatch.pl warning about 'line over 80 characters'. I just split line with function.

Signed-off-by Patryk Mezydlo <[email protected]>
---
 drivers/staging/dgnc/dgnc_tty.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_tty.c +2 -1
index 9aa0ba0..b818b0a 100644
@@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd)
 	if (IS_ERR(brd->serial_driver))
 		return PTR_ERR(brd->serial_driver);
 
-	snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum);
+	snprintf(brd->serial_name, MAXTTYNAMELEN,
+		"tty_dgnc_%d_", brd->boardnum);
 
 	brd->serial_driver->name = brd->serial_name;
 	brd->serial_driver->name_base = 0;
Signature · 1 line
2.1.4
#1 lore raw
Quoted 13 lines · Patryk Mezydlo

Fix checkpatch.pl warning about 'line over 80 characters'. I just split line with function.

Signed-off-by Patryk Mezydlo <[email protected]>
---
 drivers/staging/dgnc/dgnc_tty.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_tty.c +0 -0
index 9aa0ba0..b818b0a 100644

drivers/staging/dgnc/dgnc_tty.c int dgnc_tty_register(struct dgnc_board *brd) · line 190

Quoted 6 lines
drivers/staging/dgnc/dgnc_tty.c +2 -1
@@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd)
 	if (IS_ERR(brd->serial_driver))
 		return PTR_ERR(brd->serial_driver);
 
-	snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum);
+	snprintf(brd->serial_name, MAXTTYNAMELEN,
+		"tty_dgnc_%d_", brd->boardnum);

Why move the string to a new line? It didn't need to be there, did it?