Skip to contentSkip to conversation

staging: dgnc: remove useless error value assignment

PATCH RESEND Superseded Daeseok Youn 1 participant 1 message May 10, 2016

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Daeseok Youn

author
#0 lore raw

PATCH RESEND 2/2 staging: dgnc: remove useless error value assignment

The "result" variable in dgnc_get_mstat() was initialized with "-EIO". But if the "ch" is not null, "result" will be set to zero and if the "ch" is null, dgnc_get_mstat() will return "-ENXIO" as an error. So "-EIO" error value was useless in dgnc_get_mstat().

Signed-off-by Daeseok Youn <[email protected]>

---
RESEND: update subject and change log
origin patch : https://lkml.org/lkml/2016/5/4/13

 drivers/staging/dgnc/dgnc_tty.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +1 -3
index cff34d4..30db091 100644
@@ -1979,7 +1979,7 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
 static inline int dgnc_get_mstat(struct channel_t *ch)
 {
 	unsigned char mstat;
-	int result = -EIO;
+	int result = 0;
 	unsigned long flags;
 
 	if (!ch || ch->magic != DGNC_CHANNEL_MAGIC)

@@ -1991,8 +1991,6 @@ static inline int dgnc_get_mstat(struct channel_t *ch)
 
 	spin_unlock_irqrestore(&ch->ch_lock, flags);
 
-	result = 0;
-
 	if (mstat & UART_MCR_DTR)
 		result |= TIOCM_DTR;
 	if (mstat & UART_MCR_RTS)
Signature · 1 line
2.8.2