Skip to contentSkip to conversation

usbip: vudc: Fix apparent cut-n-paste error

PATCH Dave Jones 2 participants 2 messages May 31, 2016 – Jun 1, 2016

Subsystems (2)
USB USB over IP driver
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Coverity picked up that this looks like a cut-n-paste from an almost identical sequence below that didn't get its variable renamed.

Signed-off-by Dave Jones <[email protected]>
drivers/usb/usbip/vudc_dev.c +1 -1
index 8994a13819ab..7091848df6c8 100644
@@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
 	if (ud->tcp_socket)
 		kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
 
-	if (ud->tcp_tx) {
+	if (ud->tcp_rx) {
 		kthread_stop_put(ud->tcp_rx);
 		ud->tcp_rx = NULL;
 	}
Reviewed-by
#1 lore raw
Quoted 12 lines · Dave Jones

Coverity picked up that this looks like a cut-n-paste from an almost identical sequence below that didn't get its variable renamed.

Signed-off-by Dave Jones <[email protected]>
drivers/usb/usbip/vudc_dev.c +0 -0
index 8994a13819ab..7091848df6c8 100644

drivers/usb/usbip/vudc_dev.c static void vudc_shutdown(struct usbip_device *ud) · line 456

Quoted 8 lines
drivers/usb/usbip/vudc_dev.c +1 -1
@@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
 	if (ud->tcp_socket)
 		kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
 
-	if (ud->tcp_tx) {
+	if (ud->tcp_rx) {
 		kthread_stop_put(ud->tcp_rx);
 		ud->tcp_rx = NULL;
 	}
Reviewed-by Krzysztof Opasiak <[email protected]>
Signature · 3 lines
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics