Skip to contentSkip to conversation

drm/i915/guc: add enable_guc_loading parameter

DISCUSSION Dan Carpenter 1 participant 1 message May 31, 2016

lore
Share & tools
lore
#0 lore raw

Hello Dave Gordon,

This is a semi-automatic email about new static checker warnings.

The patch fce91f22ff31: "drm/i915/guc: add enable_guc_loading parameter" from May 20, 2016, leads to the following Smatch complaint:

drivers/gpu/drm/i915/intel_guc_loader.c:418 intel_guc_setup()
error: we previously assumed 'fw_path' could be null (see line 417)

drivers/gpu/drm/i915/intel_guc_loader.c
416 goto fail;

   417		} else if (fw_path == NULL || *fw_path == '\0') {
                           ^^^^^^^^^^^^^^^

New check.

418 if (*fw_path == '\0')

                            ^^^^^^^^^^^^^^^

Oops.

419 DRM_INFO("No GuC firmware known for this platform\n");
420 err = -ENODEV;

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx