Skip to contentSkip to conversation

extensions: libxt_connmark: Fix order of mask and mark

PATCH Applied Shivani Bhardwaj 2 participants 2 messages Jun 1, 2016 – Jun 2, 2016 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 extensions: libxt_connmark: Fix order of mask and mark

The order of mask and mark in the output is wrong. This has been pointed
out: http://git.netfilter.org/iptables/commit/?id=8548dd253833027c68ac6400c3118ef788fabe5d
by Liping Zhang <[email protected]>.
This patch fixes the same issue with connmark.

---
 extensions/libxt_connmark.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
extensions/libxt_connmark.c +2 -2
index fbfeb74..958a50c 100644
@@ -127,8 +127,8 @@ static void print_mark_xlate(unsigned int mark, unsigned int mask,
 			     struct xt_xlate *xl, uint32_t op)
 {
 	if (mask != 0xffffffffU)
-		xt_xlate_add(xl, " and 0x%x %s 0x%x ", mark,
-			   op == XT_OP_EQ ? "==" : "!=", mask);
+		xt_xlate_add(xl, " and 0x%x %s 0x%x ", mask,
+			   op == XT_OP_EQ ? "==" : "!=", mark);
 	else
 		xt_xlate_add(xl, " %s0x%x ",
 			   op == XT_OP_EQ ? "" : "!= ", mark);
Signature · 1 line
1.9.1