Skip to contentSkip to conversation

staging: lustre: lustre: obdclass: Modify return statement

PATCH In review Anchal Jain 2 participants 2 messages Jun 7, 2016 Staging

lore
Share & tools
lore

Anchal Jain

author
#0 lore raw

PATCH v2 1/1 staging: lustre: lustre: obdclass: Modify return statement

Modify the return statement.
The Coccinelle semantic patch used to make this change is as follows:

@@
expression e, ret;
@@

-ret =
+return

        e;

-return ret;

Delete the declaration of the return variable rc, as it is no longer used.

Signed-off-by Anchal Jain <[email protected]>

---
changes in v2
--add public cc with patch

 drivers/staging/lustre/lustre/obdclass/llog_cat.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/lustre/lustre/obdclass/llog_cat.c +1 -3
index c27d4ec..55f625f 100644
@@ -127,7 +127,6 @@ out:
 int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle)
 {
 	struct llog_handle	*loghandle, *n;
-	int			 rc;
 
 	list_for_each_entry_safe(loghandle, n, &cathandle->u.chd.chd_head,
 				 u.phd.phd_entry) {

@@ -138,8 +137,7 @@ int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle)
 	/* if handle was stored in ctxt, remove it too */
 	if (cathandle->lgh_ctxt->loc_handle == cathandle)
 		cathandle->lgh_ctxt->loc_handle = NULL;
-	rc = llog_close(env, cathandle);
-	return rc;
+	return llog_close(env, cathandle);
 }
 EXPORT_SYMBOL(llog_cat_close);
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 12 lines · Anchal Jain

Modify the return statement.
The Coccinelle semantic patch used to make this change is as follows:

@@
expression e, ret;
@@

(quoted diff) +1 -2
-ret =
+return
        e;
-return ret;
Quoted 7 lines

Delete the declaration of the return variable rc, as it is no longer used.

Signed-off-by Anchal Jain <[email protected]>

---
changes in v2
--add public cc with patch

Please use scripts/get_maintainer.pl to determine who and what lists to send patches to (hint, lkml is almost never the correct list to _only_ send patches to.)