Skip to contentSkip to conversation

usb: early/ehci-dbgp: make it explicitly non-modular

PATCH New Paul Gortmaker 1 participant 1 message Jun 15, 2016 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: early/ehci-dbgp: make it explicitly non-modular

The Kconfig currently controlling compilation of this code is:

arch/x86/Kconfig.debug:config EARLY_PRINTK_DBGP arch/x86/Kconfig.debug: bool "Early printk via EHCI debug port"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit.

---
 drivers/usb/early/ehci-dbgp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/early/ehci-dbgp.c +2 -2
index 8cfc3191be50..74bc2507a5bc 100644
@@ -13,7 +13,7 @@
 
 #include <linux/console.h>
 #include <linux/errno.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/pci_regs.h>
 #include <linux/pci_ids.h>
 #include <linux/usb/ch9.h>
@@ -1093,5 +1094,5 @@ static int __init kgdbdbgp_start_thread(void)
 
 	return 0;
 }
-module_init(kgdbdbgp_start_thread);
+device_initcall(kgdbdbgp_start_thread);
 #endif /* CONFIG_KGDB */
Signature · 1 line
2.5.0