Skip to contentSkip to conversation

iommu/amd: Remove create_workqueue

PATCH Applied Bhaktipriya Shridhar 3 participants 3 messages Jun 18, 2016 – Jun 21, 2016 IOMMU

lore
Share & tools
lore

Bhaktipriya Shridhar

author
#0 lore raw

PATCH 1/1 iommu/amd: Remove create_workqueue

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitem (viz &fault->work), is involved in IO page-fault handling. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure, which is a requirement here.
Since there are only a fixed number of work items, explicit concurrency limit is unnecessary.

Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/iommu/amd_iommu_v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu_v2.c +1 -1
index 56999d2f..0d52ceb 100644
@@ -961,7 +961,7 @@ static int __init amd_iommu_v2_init(void)
 	spin_lock_init(&state_lock);
 
 	ret = -ENOMEM;
-	iommu_wq = create_workqueue("amd_iommu_v2");
+	iommu_wq = alloc_workqueue("amd_iommu_v2", WQ_MEM_RECLAIM, 0);
 	if (iommu_wq == NULL)
 		goto out;

--
2.1.4

Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Bhaktipriya Shridhar

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitem (viz &fault->work), is involved in IO page-fault handling. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure, which is a requirement here.
Since there are only a fixed number of work items, explicit concurrency limit is unnecessary.

Signed-off-by Bhaktipriya Shridhar <[email protected]>
Acked-by Tejun Heo <[email protected]>

Thanks.

Signature · 1 line
tejun
maintainer Applied
#2 lore raw
In reply to Bhaktipriya Shridhar
Quoted 9 lines · Bhaktipriya Shridhar

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitem (viz &fault->work), is involved in IO page-fault handling. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure, which is a requirement here.
Since there are only a fixed number of work items, explicit concurrency limit is unnecessary.

Quoted 4 lines
Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/iommu/amd_iommu_v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.