drm/amdgpu: precedence bug in amdgpu_device_init()
Subsystems (3)
PATCH 1/1 drm/amdgpu: precedence bug in amdgpu_device_init()
! has higher precedence than bitwise & so we need to add parenthesis for this to work as intended.
Fixes 048765ad5af7 ('amdgpu: fix asic initialization for virtualized environments (v2)')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -1535,7 +1535,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,/* Post card if necessary */ if (!amdgpu_card_posted (adev) || (adev->virtualization.is_virtual && - !adev->virtualization.caps &AMDGPU_VIRT_CAPS_SRIOV_EN )) { + !(adev->virtualization.caps &AMDGPU_VIRT_CAPS_SRIOV_EN ))) {if (!adev->bios) {dev_err (adev->dev,"Card not posted and no BIOS - ignoring\n" );return -EINVAL ;
Alex Deucher
AppliedQuoted 5 lines · Dan Carpenter
! has higher precedence than bitwise & so we need to add parenthesis for this to work as intended.
Fixes 048765ad5af7 ('amdgpu: fix asic initialization for virtualized environments (v2)')Signed-off-by Dan Carpenter <[email protected]>
Applied. thanks!
Alex
Quoted 18 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -1535,7 +1535,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,/* Post card if necessary */ if (!amdgpu_card_posted (adev) || (adev->virtualization.is_virtual && - !adev->virtualization.caps &AMDGPU_VIRT_CAPS_SRIOV_EN )) { + !(adev->virtualization.caps &AMDGPU_VIRT_CAPS_SRIOV_EN ))) {if (!adev->bios) {dev_err (adev->dev,"Card not posted and no BIOS - ignoring\n" );return -EINVAL ;_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel