Skip to contentSkip to conversation

nvmet: fix an error code

PATCH In review Dan Carpenter 2 participants 2 messages Jul 7, 2016

Subsystems (3)
Kernel janitors NVMe NVMe target
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 nvmet: fix an error code

We accidentally return zero here when ERR_PTR(-ENOMEM) is intended.

Fixes a07b4970f464 ('nvmet: add a generic NVMe target')
Signed-off-by Dan Carpenter <[email protected]>
drivers/nvme/target/configfs.c +2 -2
index 9bed302..af5e2dc 100644
@@ -737,7 +737,7 @@ static struct config_group *nvmet_referral_make(
 
 	port = kzalloc(sizeof(*port), GFP_KERNEL);
 	if (!port)
-		return ERR_CAST(port);
+		return ERR_PTR(-ENOMEM);
 
 	INIT_LIST_HEAD(&port->entry);
 	config_group_init_type_name(&port->group, name, &nvmet_referral_type);

@@ -794,7 +794,7 @@ static struct config_group *nvmet_ports_make(struct config_group *group,
 
 	port = kzalloc(sizeof(*port), GFP_KERNEL);
 	if (!port)
-		return ERR_CAST(port);
+		return ERR_PTR(-ENOMEM);
 
 	INIT_LIST_HEAD(&port->entry);
 	INIT_LIST_HEAD(&port->subsystems);
maintainer
#1 lore raw
Quoted 4 lines · Dan Carpenter

We accidentally return zero here when ERR_PTR(-ENOMEM) is intended.

Fixes a07b4970f464 ('nvmet: add a generic NVMe target')
Signed-off-by Dan Carpenter <[email protected]>

Thanks Dan, added.

Signature · 1 line
Jens Axboe