tcp regression in v4.7-r1: c14ac9451c34832554db33386a4393be8bba3a7b breaks pulseaudio over TCP
Subsystems (3)
Hi netdev folk!
Commit c14ac9451c34832554db33386a4393be8bba3a7b
broke pulseaudio (PA) over TCP.
PA does unusual thing: it calls
sendmsg(cmsg_type=SCM_CREDENTIALS)
on a TCP socket. It's not a new PA behaviour though.
Originally reported as PA bug (has more details)
https://bugs.freedesktop.org/show_bug.cgi?id=96873
It looks like kernel used to ignore control messages but now it does not:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/net/ipv4/tcp.c?id=c14ac9451c34832554db33386a4393be8bba3a7b
+ if (msg->msg_controllen) {
+ err = sock_cmsg_send(sk, msg, &sockc);
+ if (unlikely(err)) {
+ err = -EINVAL;
+ goto out_err;
+ }
+ }
This change breaks streaming of pulse clients.
Pulseaudio will be fixed at some point.
But kernel change does not look like intentional
breakage of old behaviour.
Perhaps kernel should have a grace period and only warn about unsupported control messages for a socket?
Last working kernel: v4.6
Thanks!
Signature · 1 line
Sergei
Quoted 4 lines · Sergei Trofimovich
Hi netdev folk!
Commit
c14ac9451c34832554db33386a4393be8bba3a7b
broke pulseaudio (PA) over TCP.
Sorry that my patch broke your app and thanks for the bug report. Breaking PA was certainly not my intention.
Quoted 22 lines
PA does unusual thing: it calls
sendmsg(cmsg_type=SCM_CREDENTIALS)on a TCP socket. It's not a new PA behaviour though.
Originally reported as PA bug (has more details)
https://bugs.freedesktop.org/show_bug.cgi?id=96873It looks like kernel used to ignore control messages but now it does not:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/net/ipv4/tcp.c?id=c14ac9451c34832554db33386a4393be8bba3a7b(quoted diff) +7
-0+ if (msg->msg_controllen) { + err = sock_cmsg_send(sk, msg, &sockc); + if (unlikely(err)) { + err = -EINVAL; + goto out_err; + } + }This change breaks streaming of pulse clients.
Quoted 7 lines
Pulseaudio will be fixed at some point.
But kernel change does not look like intentional
breakage of old behaviour.Perhaps kernel should have a grace period and only warn about unsupported control messages for a socket?
We have discussed ignoring certain control messages in another context:
https://patchwork.ozlabs.org/patch/621837/
But the counter-argument (which I agree with) is that: we used to accept garbage in control messages before, but that doesn't mean we should give up on strict checking.
This new problem is a bit different though. We always ignore control messages of other layers:
ip_cmsg_send:
if (cmsg->cmsg_level != SOL_IP)
continue;sock_cmsg_send:
if (cmsg->cmsg_level != SOL_SOCKET)
continue;Semantically SCM_RIGHTS and SCM_CREDENTIALS belong to the SOL_UNIX layer but they are historically sent on SOL_SOCKET. I believe we should ignore them as we would if they were sent on SOL_UNIX:
net/core/sock.c +0 -0
@@ -1938,6 +1938,13 @@ int __sock_cmsg_send(struct sock *sk, struct
msghdr *msg, struct cmsghdr *cmsg,
sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK;
sockc->tsflags |= tsflags;
break;
+ /* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX
+ * yet they are sent on SOL_SOCKET. We should ignore them as
+ * we do for control messages not in the SOL_SOCKET layers.
+ */
+ case SCM_RIGHTS:
+ case SCM_CREDENTIALS:
+ break;
default:
return -EINVAL;
}David: Could you please let me know your thoughts?
Thanks!
Soheil
Quoted 7 lines
Last working kernel: v4.6
Thanks!
--
Sergei
Quoted 66 lines · On Sun, 10 Jul 2016 11:15:01 -0400 Soheil Hassas Yeganeh <[email protected]>…
Quoted 4 lines · Sergei Trofimovich
Hi netdev folk!
Commit
c14ac9451c34832554db33386a4393be8bba3a7b
broke pulseaudio (PA) over TCP.Sorry that my patch broke your app and thanks for the bug report. Breaking PA was certainly not my intention.
Quoted 22 lines
PA does unusual thing: it calls
sendmsg(cmsg_type=SCM_CREDENTIALS)on a TCP socket. It's not a new PA behaviour though.
Originally reported as PA bug (has more details)
https://bugs.freedesktop.org/show_bug.cgi?id=96873It looks like kernel used to ignore control messages but now it does not:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/net/ipv4/tcp.c?id=c14ac9451c34832554db33386a4393be8bba3a7b(quoted diff) +7
-0+ if (msg->msg_controllen) { + err = sock_cmsg_send(sk, msg, &sockc); + if (unlikely(err)) { + err = -EINVAL; + goto out_err; + } + }This change breaks streaming of pulse clients.
Quoted 7 lines
Pulseaudio will be fixed at some point.
But kernel change does not look like intentional
breakage of old behaviour.Perhaps kernel should have a grace period and only warn about unsupported control messages for a socket?
We have discussed ignoring certain control messages in another context:
https://patchwork.ozlabs.org/patch/621837/But the counter-argument (which I agree with) is that: we used to accept garbage in control messages before, but that doesn't mean we should give up on strict checking.
This new problem is a bit different though. We always ignore control messages of other layers:
ip_cmsg_send:if (cmsg->cmsg_level != SOL_IP) continue;
sock_cmsg_send:if (cmsg->cmsg_level != SOL_SOCKET) continue;Semantically
SCM_RIGHTSandSCM_CREDENTIALSbelong to theSOL_UNIXlayer but they are historically sent onSOL_SOCKET. I believe we should ignore them as we would if they were sent onSOL_UNIX:net/core/sock.c +0
-0
net/core/sock.c int __sock_cmsg_send(struct sock *sk, struct · line 1947
Quoted 10 lines
net/core/sock.c +6
-0@@ -1938,6 +1938,13 @@ int __sock_cmsg_send(struct sock *sk, struct msghdr *msg, struct cmsghdr *cmsg, sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK; sockc->tsflags |= tsflags;break ; +/* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX +* yet they are sent on SOL_SOCKET. We should ignore them as +* we do for control messages not in the SOL_SOCKET layers. +*/ +case SCM_RIGHTS : +case SCM_CREDENTIALS :
Fixes PA for me. That was quick!
Perhaps to have those applications a change be fixed in future something like
+ net_info_ratelimited("TCP(%s:%d): Application bug, <some meaningful explanation>\n",
+ current->comm,
+ task_pid_nr(current));
could signal the breakage? WDYT?
Signature · 1 line
Sergei
Quoted 73 lines · Sergei Trofimovich
Quoted 70 lines · On Sun, 10 Jul 2016 11:15:01 -0400 Soheil Hassas Yeganeh <[email protected]>…
Quoted 4 lines · Sergei Trofimovich
Hi netdev folk!
Commit
c14ac9451c34832554db33386a4393be8bba3a7b
broke pulseaudio (PA) over TCP.Sorry that my patch broke your app and thanks for the bug report. Breaking PA was certainly not my intention.
Quoted 22 lines
PA does unusual thing: it calls
sendmsg(cmsg_type=SCM_CREDENTIALS)on a TCP socket. It's not a new PA behaviour though.
Originally reported as PA bug (has more details)
https://bugs.freedesktop.org/show_bug.cgi?id=96873It looks like kernel used to ignore control messages but now it does not:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/net/ipv4/tcp.c?id=c14ac9451c34832554db33386a4393be8bba3a7b(quoted diff) +7
-0+ if (msg->msg_controllen) { + err = sock_cmsg_send(sk, msg, &sockc); + if (unlikely(err)) { + err = -EINVAL; + goto out_err; + } + }This change breaks streaming of pulse clients.
Quoted 7 lines
Pulseaudio will be fixed at some point.
But kernel change does not look like intentional
breakage of old behaviour.Perhaps kernel should have a grace period and only warn about unsupported control messages for a socket?
We have discussed ignoring certain control messages in another context:
https://patchwork.ozlabs.org/patch/621837/But the counter-argument (which I agree with) is that: we used to accept garbage in control messages before, but that doesn't mean we should give up on strict checking.
This new problem is a bit different though. We always ignore control messages of other layers:
ip_cmsg_send:if (cmsg->cmsg_level != SOL_IP) continue;
sock_cmsg_send:if (cmsg->cmsg_level != SOL_SOCKET) continue;Semantically
SCM_RIGHTSandSCM_CREDENTIALSbelong to theSOL_UNIXlayer but they are historically sent onSOL_SOCKET. I believe we should ignore them as we would if they were sent onSOL_UNIX:net/core/sock.c +0
-0@@ -1938,6 +1938,13 @@ int __sock_cmsg_send(struct sock *sk, struct msghdr *msg, struct cmsghdr *cmsg, sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK; sockc->tsflags |= tsflags;break ;
Quoted 8 lines
net/core/sock.c int __sock_cmsg_send(struct sock *sk, struct · line 1947
Quoted 6 lines
net/core/sock.c +6
-0+/* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX +* yet they are sent on SOL_SOCKET. We should ignore them as +* we do for control messages not in the SOL_SOCKET layers. +*/ +case SCM_RIGHTS : +case SCM_CREDENTIALS :Fixes PA for me. That was quick!
Thanks so much for the confirmation, Sergei!
Quoted 7 lines
Perhaps to have those applications a change be fixed in future something like
(quoted diff) +3
-0+ net_info_ratelimited("TCP(%s:%d): Application bug, <some meaningful explanation>\n", + current->comm, + task_pid_nr(current));could signal the breakage? WDYT?
IMHO, for consistency, we should simply ignore control messages of other layers, and shouldn't log anything. That's the way Linux has been ignoring control messages.
I'll mail the patch against net to have David's thoughts.
Thanks again!
Soheil
Quoted 3 lines
--
Sergei