ndctl: fix --enable-destructive build failure
PATCH 1/1 ndctl: fix --enable-destructive build failure
This commit:
commit 0d119368385a ("ndctl: reorganize file structure, use per sub-directory makefiles")
reorganized the file structure & makefiles in ndctl, but broke builds that used the --enable-destructive option. Here are some of the failure messages:
../test/blk_namespaces.o: In function `test_blk_namespaces':
/root/project/ndctl/ndctl/../test/blk_namespaces.c:222: undefined reference to __ndctl_test_attempt' /root/project/ndctl/ndctl/../test/blk_namespaces.c:250: undefined reference to __ndctl_test_skip'
The root cause of this build failure was that when --enable-destructive was being set, test/core.c wasn't being compiled and included in the build, hence the undefined references.
Fix the makefile to include test/core.c.
--- ndctl/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
ndctl/Makefile.am +2 -1
@@ -53,7 +53,8 @@ endif if ENABLE_DESTRUCTIVE ndctl_SOURCES += ../test/blk_namespaces.c \ ../test/pmem_namespaces.c \ - ../test/pcommit.c + ../test/pcommit.c \ + ../test/core.c ndctl_SOURCES += builtin-bat.c endif
Signature · 6 lines
2.9.0 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 12 lines · Ross Zwisler
This commit:
commit
0d119368385a("ndctl: reorganize file structure, use per sub-directory makefiles")reorganized the file structure & makefiles in ndctl, but broke builds that used the --enable-destructive option. Here are some of the failure messages:
../test/blk_namespaces.o: In function `test_blk_namespaces':
/root/project/ndctl/ndctl/../test/blk_namespaces.c:222: undefined reference to__ndctl_test_attempt' /root/project/ndctl/ndctl/../test/blk_namespaces.c:250: undefined reference to__ndctl_test_skip'
Quoted 8 lines
The root cause of this build failure was that when --enable-destructive was being set,
test/core.cwasn't being compiled and included in the build, hence the undefined references.Fix the makefile to include
test/core.c.Signed-off-by Ross Zwisler <[email protected]>---
Hmm, are you perhaps trying to build with --enable-destructive without --enable-test? I'll see if I can fix this up to warn about the misconfiguration, the intent is that --enable-destructive is incremental.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm