scripts/Lindent: clean up and optimize
PATCH 1/1 scripts/Lindent: clean up and optimize
* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.
--- scripts/Lindent | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
scripts/Lindent +9 -5
@@ -1,21 +1,25 @@ #!/bin/sh + PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1" -RES=`indent --version` + +RES=`indent --version | cut -d' ' -f3` if [ "$RES" = "" ]; then exit 1 fi -V1=`echo $RES | cut -d' ' -f3 | cut -d'.' -f1` -V2=`echo $RES | cut -d' ' -f3 | cut -d'.' -f2` -V3=`echo $RES | cut -d' ' -f3 | cut -d'.' -f3` +V1=`echo $RES | cut -d'.' -f1` +V2=`echo $RES | cut -d'.' -f2` +V3=`echo $RES | cut -d'.' -f3` + if [ $V1 -gt 2 ]; then PARAM="$PARAM -il0" elif [ $V1 -eq 2 ]; then if [ $V2 -gt 2 ]; then - PARAM="$PARAM -il0"; + PARAM="$PARAM -il0" elif [ $V2 -eq 2 ]; then if [ $V3 -ge 10 ]; then PARAM="$PARAM -il0" fi fi fi + indent $PARAM "$@"
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 3 lines · Jean Delvare
* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.
As it commonly reflows > 80 column code very badly, my preference would be to remove Lindent instead.
Hi Joe,
Quoted 9 lines · Joe Perches
Quoted 3 lines · Jean Delvare
* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.As it commonly reflows > 80 column code very badly, my preference would be to remove Lindent instead.
This was 3.5 years ago, so apparently it's not happening.
Why don't you just remove -l80 from the options, if this is your only concern with the script? Adding the appropriate option to indent to support what we think is good would seem even better, but I do not have any time to devote to this task.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 9 lines · Jean Delvare
Hi Joe,
Quoted 6 lines · Joe Perches
Quoted 4 lines · Jean Delvare
* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.
Quoted 8 lines
Quoted 4 lines
As it commonly reflows > 80 column code very badly, my preference would be to remove Lindent instead.
This was 3.5 years ago, so apparently it's not happening.
Why don't you just remove -l80 from the options, if this is your only concern with the script?
line length is not context aware and you'd get > 256 column lines in a lot of cases.
Quoted 3 lines
Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have any time to devote to this task.
Nor does anyone else.
indent has had 1 change in 14 years.
clang-format might be a better tool and a better suggestion than Lindent now.