Skip to contentSkip to conversation

clk: fixed-factor: Remove export symbol on setup function

PATCH Applied Stephen Boyd 2 participants 7 messages Aug 13, 2016 – Aug 17, 2016 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 clk: fixed-factor: Remove export symbol on setup function

This function is marked __init, so it can't possibly need to be exported to modules. Remove the marking.

Cc Gregory CLEMENT <[email protected]>
---
 drivers/clk/clk-fixed-factor.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/clk-fixed-factor.c +0 -1
index 070d0d75da97..a5d402de5584 100644
@@ -196,7 +196,6 @@ void __init of_fixed_factor_clk_setup(struct device_node *node)
 {
 	_of_fixed_factor_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_factor_clk_setup);
 CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock",
 		of_fixed_factor_clk_setup);
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw

PATCH 2/2 clk: fixed-rate: Remove export symbol on setup function

This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init.

---
 drivers/clk/clk-fixed-rate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/clk-fixed-rate.c +1 -2
index c735272ed706..b5c46b3f8764 100644
@@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void of_fixed_clk_setup(struct device_node *node)
+void __init of_fixed_clk_setup(struct device_node *node)
 {
 	_of_fixed_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
 
 static int of_fixed_clk_remove(struct platform_device *pdev)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author Applied
#2 lore raw

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

In reply to Stephen Boyd
Quoted 9 lines · Stephen Boyd

This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init.

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#3 lore raw

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

In reply to Stephen Boyd

Hi Stephen,

Quoted 17 lines · Stephen Boyd

This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init.

---
 drivers/clk/clk-fixed-rate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/clk-fixed-rate.c +0 -0
index c735272ed706..b5c46b3f8764 100644

drivers/clk/clk-fixed-rate.c static struct clk *_of_fixed_clk_setup(struct device_node *node) · line 197

Quoted 10 lines
drivers/clk/clk-fixed-rate.c +1 -2
@@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void of_fixed_clk_setup(struct device_node *node)
+void __init of_fixed_clk_setup(struct device_node *node)
 {
        _of_fixed_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);

This function is needed to instantiate clocks from DT overlays, which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

Quoted 25 lines · Geert Uytterhoeven

Hi Stephen,

Quoted 22 lines · Stephen Boyd

This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init.

---
 drivers/clk/clk-fixed-rate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/clk-fixed-rate.c +1 -1
index c735272ed706..b5c46b3f8764 100644
@@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void of_fixed_clk_setup(struct device_node *node)
+void __init of_fixed_clk_setup(struct device_node *node)
Quoted 9 lines

drivers/clk/clk-fixed-rate.c static struct clk *_of_fixed_clk_setup(struct device_node *node) · line 197

Quoted 5 lines
drivers/clk/clk-fixed-rate.c +0 -1
 {
        _of_fixed_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);

This function is needed to instantiate clocks from DT overlays, which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".

I think Ricardo's latest series should make that work for you with platform device drivers?

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#5 lore raw

Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

Hi Stephen,

Quoted 33 lines · Stephen Boyd
Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines · Stephen Boyd

This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init.

---
 drivers/clk/clk-fixed-rate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/clk-fixed-rate.c +1 -1
index c735272ed706..b5c46b3f8764 100644
@@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void of_fixed_clk_setup(struct device_node *node)
+void __init of_fixed_clk_setup(struct device_node *node)
Quoted 8 lines

drivers/clk/clk-fixed-rate.c static struct clk *_of_fixed_clk_setup(struct device_node *node) · line 197

Quoted 5 lines
drivers/clk/clk-fixed-rate.c +0 -1
 {
        _of_fixed_clk_setup(node);
 }
-EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);

This function is needed to instantiate clocks from DT overlays, which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".

Quoted 2 lines

I think Ricardo's latest series should make that work for you with platform device drivers?

Thanks, I had missed that series.
Ah, that one calls _of_fixed_clk_setup() instead, which should still work.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds