drm/amd/amdgpu: debugfs SMC addresses are byte addresses
Subsystems (2)
PATCH 1/1 drm/amd/amdgpu: debugfs SMC addresses are byte addresses
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -2
@@ -2678,7 +2678,7 @@ static ssize_t amdgpu_debugfs_regs_smc_read(struct file *f, char __user *buf,while (size) {uint32_t value; - value =RREG32_SMC (*pos >>2 ); + value =RREG32_SMC (*pos); r =put_user (value, (uint32_t *)buf);if (r)return r;
@@ -2709,7 +2709,7 @@ static ssize_t amdgpu_debugfs_regs_smc_write(struct file *f, const char __user *if (r)return r; -WREG32_SMC (*pos >>2 , value); +WREG32_SMC (*pos, value); result +=4 ; buf +=4 ;
Signature · 6 lines
2.9.3 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Christian König
Reviewed-byAm 29.08.2016 um 15:06 schrieb Tom St Denis:
Quoted 1 line
Signed-off-by Tom St Denis <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -2678,7 +2678,7 @@ static ssize_t amdgpu_debugfs_regs_smc_read(struct file *f, char __user *buf,while (size) {uint32_t value; - value =RREG32_SMC (*pos >>2 ); + value =RREG32_SMC (*pos); r =put_user (value, (uint32_t *)buf);if (r)return r;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static ssize_t amdgpu_debugfs_regs_smc_write(struct file *f, const char __user * · line 2715
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -2709,7 +2709,7 @@ static ssize_t amdgpu_debugfs_regs_smc_write(struct file *f, const char __user *if (r)return r; -WREG32_SMC (*pos >>2 , value); +WREG32_SMC (*pos, value); result +=4 ; buf +=4 ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Reviewed-by Alex DeucherQuoted 10 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Monday, August 29, 2016 9:06 AM
To: [email protected]
Cc: StDenis, Tom
Subject: [PATCH] drm/amd/amdgpu: debugfs SMC addresses are byte addressesSigned-off-by Tom St Denis <[email protected]>
FWIW, all of the indirect register apertures use byte aligned indicies.
Alex
Quoted 32 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -2678,7 +2678,7 @@ static ssize_t amdgpu_debugfs_regs_smc_read(struct file *f, char __user *buf, while (size) { uint32_t value; - value =RREG32_SMC (*pos >>2 ); + value =RREG32_SMC (*pos); r =put_user (value, (uint32_t *)buf);if (r)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0return r;@@ -2709,7 +2709,7 @@ static ssize_tamdgpu_debugfs_regs_smc_write(struct file *f, const char
__user*drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-2if (r)return r; -WREG32_SMC (*pos >>2 , value); +WREG32_SMC (*pos, value); result +=4 ; buf +=4 ; --2.9.3
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx