Skip to contentSkip to conversation

staging: i4l: act2000: Add blank line after declaration

PATCH In review Anson Jacob 2 participants 2 messages Sep 2, 2016 Staging

lore
Share & tools
lore

Anson Jacob

author
#0 lore raw

PATCH 1/1 staging: i4l: act2000: Add blank line after declaration

Fix checkpatch.pl warning:
Missing a blank line after declarations

Signed-off-by Anson Jacob <[email protected]>
---
 drivers/staging/i4l/act2000/act2000_isa.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/i4l/act2000/act2000_isa.c +1 -0
index 1d93151..fbb15f5 100644
@@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card)
 					       "act2000_isa_receive: Invalid CAPI msg\n");
 					{
 						int i; __u8 *p; __u8 *t; __u8 tmp[30];
+
 						for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
 							t += sprintf(t, "%02x ", *(p++));
 						printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Anson Jacob

Fix checkpatch.pl warning:
Missing a blank line after declarations

[]

drivers/staging/i4l/act2000/act2000_isa.c

Quoted 1 line
drivers/staging/i4l/act2000/act2000_isa.c +0 -0

[]

drivers/staging/i4l/act2000/act2000_isa.c act2000_isa_receive(act2000_card *card) · line 265

Quoted 8 lines
drivers/staging/i4l/act2000/act2000_isa.c +1 -0
@@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card)
  					       "act2000_isa_receive: Invalid CAPI msg\n");
  					{
  						int i; __u8 *p; __u8 *t; __u8 tmp[30];
+
  						for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
  							t += sprintf(t, "%02x ", *(p++));
  						printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);

It'd be better to use the %*ph vsprintf extension
(see Documentation/printk-formats.txt) without
any of the loop code and variable declarations:

						pr_warn("%s: %8ph\n",
							__func__, card->idat.isa.rcvhdr);
or maybe
						pr_warn("%s: %*ph\n",
							__func__,
							(int)ARRAY_SIZE(card->idat.isa.rcvhdr),
							card->idat.isa.rcvhdr);