Skip to contentSkip to conversation

dmaengine: mxs: remove NO_IRQ check

PATCH New Arnd Bergmann 1 participant 1 message Sep 2, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: mxs: remove NO_IRQ check

The mxs_chan->chan_irq variable is guaranteed to never be NO_IRQ, as it gets assigned the result of platform_get_irq() that returns either a valid positive interrupt number, or a negative failure code that leads to the channel not being used.

This removes the redundant check, eliminating one more instance of NO_IRQ.

---
 drivers/dma/mxs-dma.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/dma/mxs-dma.c +4 -6
index 50e64e113ffb..e217268c7098 100644
@@ -428,12 +428,10 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan)
 		goto err_alloc;
 	}
 
-	if (mxs_chan->chan_irq != NO_IRQ) {
-		ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
-					0, "mxs-dma", mxs_dma);
-		if (ret)
-			goto err_irq;
-	}
+	ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
+			  0, "mxs-dma", mxs_dma);
+	if (ret)
+		goto err_irq;
 
 	ret = clk_prepare_enable(mxs_dma->clk);
 	if (ret)
Signature · 1 line
2.9.0