Skip to contentSkip to conversation

macsec: set network devtype

PATCH Applied Stephen Hemminger 3 participants 4 messages Sep 7, 2016 – Sep 9, 2016

Subsystems (3)
Networking Network drivers Networking macsec
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 macsec: set network devtype

The netdevice type structure for macsec was being defined but never used. To set the network device type the macro SET_NETDEV_DEVTYPE must be called. Compile tested only, I don't use macsec.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/macsec.c +1 -0
@@ -2973,6 +2973,7 @@ static void macsec_setup(struct net_devi
 	dev->priv_flags |= IFF_NO_QUEUE;
 	dev->netdev_ops = &macsec_netdev_ops;
 	dev->destructor = macsec_free_netdev;
+	SET_NETDEV_DEVTYPE(dev, &macsec_type);
 
 	eth_zero_addr(dev->broadcast);
 }
maintainer
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Wed, 7 Sep 2016 14:07:32 -0700

Quoted 5 lines

The netdevice type structure for macsec was being defined but never used. To set the network device type the macro SET_NETDEV_DEVTYPE must be called. Compile tested only, I don't use macsec.

Signed-off-by Stephen Hemminger <[email protected]>

Sabrina, please review.

Thanks.

maintainer Acked-by
#2 lore raw
Quoted 7 lines · David Miller

From: Stephen Hemminger <[email protected]>
Date: Wed, 7 Sep 2016 14:07:32 -0700

Quoted 4 lines

The netdevice type structure for macsec was being defined but never used. To set the network device type the macro SET_NETDEV_DEVTYPE must be called. Compile tested only, I don't use macsec.

Quoted 5 lines
Quoted 1 line
Signed-off-by Stephen Hemminger <[email protected]>

Sabrina, please review.

Thanks.

Sorry for the delay. LGTM:

Acked-by Sabrina Dubroca <[email protected]>
Signature · 1 line
Sabrina