fmc: don't include moduleparam.h in include/linux header files.
PATCH 1/1 fmc: don't include moduleparam.h in include/linux header files.
We try to keep cross linkages between include/linux files to a minimum wherever possible. To that end, we avoid having the include/linux headers sourcing module.h or moduleparam.h (which sources module.h).
Here we see moduleparam.h was included in one for the following:
/* These are the generic parameters, that drivers may instantiate */
#define FMC_PARAM_BUSID(_d) \
module_param_array_named(busid, _d.busid_val, int, &_d.busid_n, 0444)
#define FMC_PARAM_GATEWARE(_d) \
module_param_array_named(gateware, _d.gw_val, charp, &_d.gw_n, 0444)However, since they are #define, it is the driver's responsibility to include moduleparam.h should it decide to make use of any of these.
So move the include to the one and only driver to use these macros and ensure we keep setting the proper example in include/linux headers.
--- drivers/fmc/fmc-trivial.c | 1 + include/linux/fmc.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/fmc/fmc-trivial.c +1 -0
@@ -13,6 +13,7 @@/* A trivial fmc driver that can load a gateware file and reports interrupts */ #include <linux/module.h> +#include <linux/moduleparam.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/gpio.h>
include/linux/fmc.h +0 -1
@@ -10,7 +10,6 @@#ifndef __LINUX_FMC_H__#define __LINUX_FMC_H__#include <linux/types.h> -#include <linux/moduleparam.h> #include <linux/device.h> #include <linux/list.h> #include <linux/interrupt.h>
Signature · 1 line
2.8.4
Quoted 5 lines
So move the include to the one and only driver to use these macros and ensure we keep setting the proper example in
include/linuxheaders.Cc Alessandro Rubini <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Thanks.