iio: accel: sca3000_core: Fix superfluous indent white space

PATCH In review Ico Doornekamp 3 participants 9 messages Sep 9, 2016 – Sep 20, 2016

Subsystems (3)

Staging IIO Staging - industrial io

lore

Share & tools

lore

Ico Doornekamp

author

2016-09-09 17:45 UTC #0 lore raw

PATCH 1/1 iio: accel: sca3000_core: Fix superfluous indent white space

Signed-off-by Ico Doornekamp <[email protected]>

---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/iio/accel/sca3000_core.c +1 -1

index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),

Signature · 1 line

2.9.3

Jonathan Cameron

maintainer

2016-09-10 14:57 UTC #1 lore raw

Quoted 1 line · Ico Doornekamp

Signed-off-by Ico Doornekamp <[email protected]>

Clifton Barnes sent a patch for this a few weeks ago and I have already applied that patch.

Thanks,

Jonathan

Quoted 18 lines

---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/iio/accel/sca3000_core.c +1 -1

index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),

Ico Doornekamp

author

2016-09-10 16:01 UTC #2 lore raw

Quoted 2 lines · * On 2016-09-10 16:57:18 +0200, Jonathan Cameron wrote:

Clifton Barnes sent a patch for this a few weeks ago and I have already applied that patch.

Oh, so I'm probably working from the wrong tree, linux-next seems to be behind on this; does linux-iio have its own git tree somewhere?

(I'm sorry if I'm generating noise on the list here. As is probably obvious, I'm here because of the The Eudyptula Challenge [1]; the current task being to fix a style violation somewhere in the staging tree. Since IIO is the single part of the staging tree I actually use in real life, I though this might be the right place for me to come to. Too bad for me that there's not much style issues in the IIO tree though)

1. http://eudyptula-challenge.org/

Signature · 2 lines

:wq
^X^Cy^K^X^C^C^C^C

Jonathan Cameron

maintainer

2016-09-10 16:26 UTC #3 lore raw

Quoted 7 lines · Ico Doornekamp

Quoted 2 lines · * On 2016-09-10 16:57:18 +0200, Jonathan Cameron wrote:
Clifton Barnes sent a patch for this a few weeks ago and I have already applied that patch.
Oh, so I'm probably working from the wrong tree, linux-next seems to be behind on this; does linux-iio have its own git tree somewhere?

Yes
https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/

Most recent branch if normally 'testing' which is there for the various automated build tests to report on.

Path to linux next is that I have to send Greg KH a pull request (will be doing one tomorrow probably) and then he pulls it into staging-next which is pulled into linux-next.

Quoted 6 lines

(I'm sorry if I'm generating noise on the list here. As is probably obvious, I'm here because of the The Eudyptula Challenge [1]; the current task being to fix a style violation somewhere in the staging tree. Since IIO is the single part of the staging tree I actually use in real life, I though this might be the right place for me to come to.

Cool

Quoted 2 lines

Too bad for me that there's not much style issues in the IIO tree though)

Largely because others have been here before you and picked off the low hanging fruit. All our remaining staging drivers have been there a 'long' time!

Quoted 2 lines

1. http://eudyptula-challenge.org/

Don't worry about it! We are always happy to help out people who
are just getting started.

If you want to try something a little more 'meaty' take a staging driver and play spot the ABI that is either 'wrong' or not yet documented under

Documentation/ABI/testing/sysfs-bus-iio*

If it's obviously not covered by the ABI docs then post a documentation patch. This often kicks off a discussion on what the interface 'should' be ;)

Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.

For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.

Not a trivial job, but not too hard to figure out perhaps?

+ a good step up from white space patches.

Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)

Jonathan

Ico Doornekamp

author

2016-09-10 18:16 UTC #4 lore raw

Quoted 9 lines · * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:

Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.
For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.
Not a trivial job, but not too hard to figure out perhaps?

Not too hard, although I'm not able to actually run and test due to lack of hardware.

Quoted 1 line

+ a good step up from white space patches.

I do hope the Little Penguin agrees on this :)

Quoted 3 lines

Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)

I have no clue: I'm trying to stick to the steps and not peek ahead.

Signature · 2 lines

:wq
^X^Cy^K^X^C^C^C^C

Jonathan Cameron

maintainer

2016-09-13 17:37 UTC #5 lore raw

Quoted 10 lines · Ico Doornekamp

Quoted 8 lines · * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.
For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.

Quoted 4 lines

Quoted 1 line
Not a trivial job, but not too hard to figure out perhaps?
Not too hard, although I'm not able to actually run and test due to lack of hardware.

That's fine. This one is my driver (rather needing some care and attention) and I have the hardware still. It's somewhat of a pain to fire up so I might do this one just on review but we'll see how busy I am at the weekend.

Quoted 4 lines

Quoted 2 lines
+ a good step up from white space patches.
I do hope the Little Penguin agrees on this :)

Should do!

Quoted 7 lines

Quoted 4 lines
Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)
I have no clue: I'm trying to stick to the steps and not peek ahead.

Alison Schofield

2016-09-13 19:22 UTC #6 lore raw

Quoted 6 lines · Jonathan Cameron

Quoted 5 lines · Ico Doornekamp
Quoted 3 lines · * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.
Not a trivial job, but not too hard to figure out perhaps?

Not trying to hijack Ico's work ;) but wondering if this task, applied to staging drivers, would be good to offer to this round of Outreachy applicants as a small coding task?

alisons

Quoted 22 lines

Quoted 3 lines
Not too hard, although I'm not able to actually run and test due to lack of hardware.
That's fine. This one is my driver (rather needing some care and attention) and I have the hardware still. It's somewhat of a pain to fire up so I might do this one just on review but we'll see how busy I am at the weekend.
Quoted 4 lines
Quoted 2 lines
+ a good step up from white space patches.
I do hope the Little Penguin agrees on this :)
Should do!
Quoted 7 lines
Quoted 4 lines
Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)
I have no clue: I'm trying to stick to the steps and not peek ahead.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jonathan Cameron

maintainer

2016-09-18 10:53 UTC #7 lore raw

Quoted 12 lines · Alison Schofield

Quoted 11 lines · Jonathan Cameron
Quoted 10 lines · Ico Doornekamp
Quoted 8 lines · * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.
For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.

Quoted 5 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Not a trivial job, but not too hard to figure out perhaps?
Not trying to hijack Ico's work ;) but wondering if this task, applied to staging drivers, would be good to offer to this round of Outreachy applicants as a small coding task?

There are probably other cases still out there. Wouldn't guarantee they are all in staging either!

Commenting out the relevant macros in include/linux/iio/sysfs.h is a good way to find these. The whole shared_by_... stuff is 'relatively recent' so quite a few drivers predate it.

Good to get them cleaned up and it's not a bad step up from white space fixes (as Ico has just demonstrated ;)

Thanks,

Jonathan

Quoted 30 lines

alisons
Quoted 16 lines
Quoted 3 lines
Not too hard, although I'm not able to actually run and test due to lack of hardware.
That's fine. This one is my driver (rather needing some care and attention) and I have the hardware still. It's somewhat of a pain to fire up so I might do this one just on review but we'll see how busy I am at the weekend.
Quoted 4 lines
Quoted 2 lines
+ a good step up from white space patches.
I do hope the Little Penguin agrees on this :)
Should do!
Quoted 5 lines
Quoted 4 lines
Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)
Quoted 6 lines
Quoted 2 lines
I have no clue: I'm trying to stick to the steps and not peek ahead.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Alison Schofield

2016-09-20 19:50 UTC #8 lore raw

Quoted 25 lines · Jonathan Cameron

Quoted 12 lines · Alison Schofield
Quoted 11 lines · Jonathan Cameron
Quoted 10 lines · Ico Doornekamp
Quoted 8 lines · * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
Another good one is to find things in staging drivers that we now have IIO_INFO_* elements for.
For example in sca3000 I see there is an explicit attribute defined that could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the relevant masks and appropriate sections added to the read_raw and write_raw callbacks.
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Not a trivial job, but not too hard to figure out perhaps?
Not trying to hijack Ico's work ;) but wondering if this task, applied to staging drivers, would be good to offer to this round of Outreachy applicants as a small coding task?
There are probably other cases still out there. Wouldn't guarantee they are all in staging either!
Commenting out the relevant macros in include/linux/iio/sysfs.h is a good way to find these. The whole shared_by_... stuff is 'relatively recent' so quite a few drivers predate it.

Quoted 7 lines

Good to get them cleaned up and it's not a bad step up from white space fixes (as Ico has just demonstrated ;)
Thanks,
Jonathan

OK, it's out there as a task for Outreachy applicants. Hopefully you'll see some incoming shortly.
(https://kernelnewbies.org/IIO_tasks)
alisons

Quoted 31 lines

Quoted 30 lines
alisons
Quoted 16 lines
Quoted 3 lines
Not too hard, although I'm not able to actually run and test due to lack of hardware.
That's fine. This one is my driver (rather needing some care and attention) and I have the hardware still. It's somewhat of a pain to fire up so I might do this one just on review but we'll see how busy I am at the weekend.
Quoted 4 lines
Quoted 2 lines
+ a good step up from white space patches.
I do hope the Little Penguin agrees on this :)
Should do!
Quoted 5 lines
Quoted 4 lines
Guess maybe that needs to be a bit later if you are ploughing through the eudyptula-challenge (though that didn't exist when I got started so I don't know what order they do stuff in!)
Quoted 6 lines
Quoted 2 lines
I have no clue: I'm trying to stick to the steps and not peek ahead.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html