ixgbe: reset before SRIOV init to avoid mailbox issues
Subsystems (2)
PATCH 1/1 ixgbe: reset before SRIOV init to avoid mailbox issues
Enabling SRIOV while the ixgbevf driver is loaded will result in all mailbox requests from ixgbevf_open() being rejected by ixgbe because adapter->clear_to_send is set to false on reset.
Call ixgbe_sriov_reinit() before pci_enable_sriov() to make sure that mailbox requests are handled from the time ixgbevf is loaded.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +3 -1
@@ -329,13 +329,15 @@ static int ixgbe_pci_sriov_enable(struct pci_dev *dev, int num_vfs)for (i =0 ; i < adapter->num_vfs; i++)ixgbe_vf_configuration (dev, (i |0x10000000 )); +/* reset before enabling SRIOV to avoid mailbox issues */ +ixgbe_sriov_reinit (adapter); + err =pci_enable_sriov (dev, num_vfs);if (err) {e_dev_warn ("Failed to enable PCI sriov: %d\n" , err);return err; }ixgbe_get_vfs (adapter); -ixgbe_sriov_reinit (adapter);return num_vfs;#else
Bowers
PATCH 1/1 ixgbe: reset before SRIOV init to avoid mailbox issues
Quoted 12 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Emil Tantilov
Sent: Friday, September 09, 2016 12:59 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH] ixgbe: reset before SRIOV init to avoid mailbox issuesEnabling SRIOV while the ixgbevf driver is loaded will result in all mailbox requests from
ixgbevf_open()being rejected by ixgbe becauseadapter->clear_to_sendis set to false on reset.
Quoted 8 lines
Call
ixgbe_sriov_reinit()beforepci_enable_sriov()to make sure that mailbox requests are handled from the time ixgbevf is loaded.Reported-by Andrew Bowers <[email protected]>Signed-off-by Emil Tantilov <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Issue is no longer present