Skip to contentSkip to conversation

Staging: bus: Space required before the open parenthesis '('.

PATCH In review Sandhya Bankar 2 participants 2 messages Sep 12, 2016 – Sep 13, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: bus: Space required before the open parenthesis '('.

Space required before the open parenthesis '('.This patch is found by checkpatch.pl script.

---
 drivers/bus/arm-cci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/arm-cci.c +1 -1
index 9e1020f..99513f7 100644
@@ -2271,7 +2271,7 @@ static int cci_probe(void)
 	struct resource res;
 
 	np = of_find_matching_node(NULL, arm_cci_matches);
-	if(!np || !of_device_is_available(np))
+	if (!np || !of_device_is_available(np))
 		return -ENODEV;
 
 	ret = of_address_to_resource(np, 0, &res);
Signature · 1 line
1.8.2.3
#1 lore raw
Quoted 1 line · Sandhya Bankar

Space required before the open parenthesis '('.This patch is found by checkpatch.pl script.

Commit log contains more than 80 characters in the single line. Usually we follow 80 characters rule for the commit log, subject as well.

Normally is useful to run checkpatch.pl on your patch. You can do that with following command after creating patch:

scripts/checkpatch.pl <file.patch>

Quoted 27 lines
---
 drivers/bus/arm-cci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/arm-cci.c +1 -2
index 9e1020f..99513f7 100644
@@ -2271,7 +2271,7 @@ static int cci_probe(void)
        struct resource res;
 
        np = of_find_matching_node(NULL, arm_cci_matches);
-       if(!np || !of_device_is_available(np))
+       if (!np || !of_device_is_available(np))
                return -ENODEV;
 
        ret = of_address_to_resource(np, 0, &res);
--

1.8.2.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912195642.GA2775%40sandhya.
For more options, visit https://groups.google.com/d/optout.

Signature · 2 lines
Vaishali
http://vaishalithakkar.in/