Skip to contentSkip to conversation

Staging: speakup: Spaces preferred around operator.

PATCH In review Sandhya Bankar 2 participants 2 messages Sep 12, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: speakup: Spaces preferred around operator.

Spaces preferred around operator.This issue is found by checkpatch.pl

---
 drivers/staging/speakup/selection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/selection.c +1 -1
index 0149edc..ce4b946 100644
@@ -99,7 +99,7 @@ int speakup_set_selection(struct tty_struct *tty)
 	sel_start = new_sel_start;
 	sel_end = new_sel_end;
 	/* Allocate a new buffer before freeing the old one ... */
-	bp = kmalloc((sel_end-sel_start)/2+1, GFP_ATOMIC);
+	bp = kmalloc((sel_end - sel_start) / 2 + 1, GFP_ATOMIC);
 	if (!bp) {
 		speakup_clear_selection();
 		return -ENOMEM;
Signature · 1 line
1.8.2.3
#1 lore raw
Quoted 1 line · Sandhya Bankar

Spaces preferred around operator.This issue is found by checkpatch.pl

There should be a space after the . after operator.

Is Greg the only maintainer for this?

julia

Quoted 29 lines
---
 drivers/staging/speakup/selection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/selection.c +1 -2
index 0149edc..ce4b946 100644
@@ -99,7 +99,7 @@ int speakup_set_selection(struct tty_struct *tty)
 	sel_start = new_sel_start;
 	sel_end = new_sel_end;
 	/* Allocate a new buffer before freeing the old one ... */
-	bp = kmalloc((sel_end-sel_start)/2+1, GFP_ATOMIC);
+	bp = kmalloc((sel_end - sel_start) / 2 + 1, GFP_ATOMIC);
 	if (!bp) {
 		speakup_clear_selection();
 		return -ENOMEM;
--

1.8.2.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160912211129.GA3309%40sandhya.
For more options, visit https://groups.google.com/d/optout.