Skip to contentSkip to conversation

Staging: iio: adc: Add space around '-'

PATCH In review Sandhya Bankar 3 participants 5 messages Sep 14, 2016 – Sep 16, 2016 1 message not in the archive

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Sandhya Bankar

author
#0 lore raw

PATCH 1/1 Staging: iio: adc: Add space around '-'

Add space around operator '-' .
This patch is found by checkpatch.pl script .
CHECK: spaces preferred around that '-' (ctx:VxV) .

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +1 -1
index 1cf6b79..5688b29 100644
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,
 			     S_IRUGO, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
Signature · 1 line
1.8.2.3
#1 lore raw

Is there no other maintainer that should receive this?

julia

Quoted 32 lines · Sandhya Bankar

Add space around operator '-' .
This patch is found by checkpatch.pl script .
CHECK: spaces preferred around that '-' (ctx:VxV) .

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +1 -2
index 1cf6b79..5688b29 100644
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,
 			     S_IRUGO, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
--

1.8.2.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40sandhya.
For more options, visit https://groups.google.com/d/optout.

author
#2 lore raw
Quoted 36 lines · Julia Lawall

Is there no other maintainer that should receive this?

julia

Review

Quoted 10 lines · Sandhya Bankar

Add space around operator '-' .
This patch is found by checkpatch.pl script .
CHECK: spaces preferred around that '-' (ctx:VxV) .

Signed-off-by Sandhya Bankar <[email protected] <javascript:>>

---

 drivers/staging/iio/adc/ad7192.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/iio/adc/ad7192.c

drivers/staging/iio/adc/ad7192.c ad7192_show_scale_available(struct device *dev, · line 395

Quoted 10 lines

index 1cf6b79..5688b29 100644

drivers/staging/iio/adc/ad7192.c +1 -1
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, 
 } 
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, 
-                             in_voltage-voltage_scale_available, 
+                             in_voltage - voltage_scale_available, 
                              S_IRUGO, ad7192_show_scale_available,

NULL, 0);

Quoted 7 lines
drivers/staging/iio/adc/ad7192.c +0 -1
 static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, 
--

1.8.2.3

Signature · 1 line
You received this message because you are subscribed to the Google
Quoted 10 lines

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40sandhya.

Quoted 1 line

For more options, visit https://groups.google.com/d/optout.

Thanks for pointing out. I will do that with v2.

#3 lore raw
Quoted 54 lines · Sandhya Bankar

On Wednesday, September 14, 2016 at 5:58:33 PM UTC+5:30, Julia Lawall wrote:

      Is there no other maintainer that should receive this?

      julia

      On Wed, 14 Sep 2016, Sandhya Bankar wrote:

      > Add space around operator '-' .
      > This patch is found by checkpatch.pl script .
      > CHECK: spaces preferred around that '-' (ctx:VxV) .
      >
      > Signed-off-by: Sandhya Bankar <[email protected]>
      > ---
      >  drivers/staging/iio/adc/ad7192.c | 2 +-
      >  1 file changed, 1 insertion(+), 1 deletion(-)
      >
      > diff --git a/drivers/staging/iio/adc/ad7192.c
      b/drivers/staging/iio/adc/ad7192.c
      > index 1cf6b79..5688b29 100644
      > --- a/drivers/staging/iio/adc/ad7192.c
      > +++ b/drivers/staging/iio/adc/ad7192.c
      > @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device
      *dev,
      >  }
      >
      >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
      > -                            
      in_voltage-voltage_scale_available,
      > +                             in_voltage -
      voltage_scale_available,
      >                               S_IRUGO,
      ad7192_show_scale_available, NULL, 0);
      >
      >  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
      > --
      > 1.8.2.3
      >
      > --
      > You received this message because you are subscribed to the
      Google Groups "outreachy-kernel" group.
      > To unsubscribe from this group and stop receiving emails from
      it, send an email to [email protected].
      > To post to this group, send email to
      [email protected].
      > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20160914110228.GA3269%40
      sandhya.
      > For more options, visit https://groups.google.com/d/optout.
Quoted 1 line

 Thanks for pointing out. I will do that with v2.

OK. While you should not top post, it is also good to respond right under what the other person has said, instead of the end of the message.

julia

Quoted 12 lines

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/35a8014f-c63b-46eb-87fe- e54db1d9d8a3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#5 lore raw
In reply to a message not in the archive
Quoted 7 lines · Katherine Dunne
Quoted 4 lines · Sandhya Bankar

Add space around operator '-' .
This patch is found by checkpatch.pl script .
CHECK: spaces preferred around that '-' (ctx:VxV) .

Hi Sandhya,

This is a false positive from checkpatch. To save you some time here is the response from Jonathan:

"Just to explain a bit more. Checkpatch is assuming that it is looking at two parameters. It's not. That's a string being passed into the macro. It ultimately forms a file name in sysfs.

p.s. We get patches for this from time to time ;( Unfortunately it's a somewhat obscure case for checkpatch."

Regards,
Katie

Quoted 24 lines
Quoted 24 lines
Signed-off-by Sandhya Bankar <[email protected] <javascript:>>

---

 drivers/staging/iio/adc/ad7192.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +1 -1
index 1cf6b79..5688b29 100644 
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, 
 } 
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, 
-                             in_voltage-voltage_scale_available, 
+                             in_voltage - voltage_scale_available, 
                              S_IRUGO, ad7192_show_scale_available, NULL, 
 0);

static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,

Signature · 1 line
1.8.2.3