Staging: sm750fb: Use x instead of x != NULL
Subsystems (2)
PATCH 1/1 Staging: sm750fb: Use x instead of x != NULL
Use x instead of x != NULL .
This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script .
CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -45,7 +45,7 @@ int dviInit(dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl->pfnInit !=NULL ) { +if (pCurrentDviCtrl->pfnInit) {return pCurrentDviCtrl->pfnInit (edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, pllFilterEnable, pllFilterValue);
Signature · 1 line
1.8.2.3
Quoted 3 lines · Sandhya Bankar
Use x instead of x != NULL .
This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script .
CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
OK for the patch, but please put a space after the end of each sentence, and don't allow the lines in your commit message to go over 80 characters.
julia
Quoted 29 lines
Signed-off-by Sandhya Bankar <[email protected]>--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/sm750fb/ddk750_dvi.c +1
-2@@ -45,7 +45,7 @@ int dviInit(dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl->pfnInit !=NULL ) { +if (pCurrentDviCtrl->pfnInit) {return pCurrentDviCtrl->pfnInit (edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, pllFilterEnable, pllFilterValue); --1.8.2.3
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914123349.GA3770%40sandhya.
For more options, visit https://groups.google.com/d/optout.