Staging: wlan-ng: Use !x instead of x == NULL.

PATCH Superseded Sandhya Bankar 2 participants 2 messages Sep 15, 2016 Staging

lore

Share & tools

lore

Sandhya Bankar

author

2016-09-15 08:04 UTC #0 lore raw

PATCH 1/1 Staging: wlan-ng: Use !x instead of x == NULL.

Use !x instead of x == NULL.
This patch is detected by checkpatch.pl script.

Signed-off-by Sandhya Bankar <[email protected]>

---
 drivers/staging/wlan-ng/cfg80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/wlan-ng/cfg80211.c +2 -2

index a36e40d..884d0d5 100644
@@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 
 	memset(sinfo, 0, sizeof(*sinfo));
 
-	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
+	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
 		return -EOPNOTSUPP;
 
 	/* build request message */

@@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 	quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
 
 	/* send message to nsd */
-	if (wlandev->mlmerequest == NULL)
+	if (!wlandev->mlmerequest)
 		return -EOPNOTSUPP;
 
 	result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);

Signature · 1 line

1.8.2.3

Julia Lawall

2016-09-15 08:05 UTC #1 lore raw

Quoted 2 lines · Sandhya Bankar

Use !x instead of x == NULL.
This patch is detected by checkpatch.pl script.

The second sentence owuld be better as:

This issue was detected by checkpatch.

I guess you made the patch yourself.

julia

Quoted 39 lines

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +2 -3
index a36e40d..884d0d5 100644
@@ -265,7 +265,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 
 	memset(sinfo, 0, sizeof(*sinfo));
 
-	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
+	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
 		return -EOPNOTSUPP;
 
 	/* build request message */
@@ -274,7 +274,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 	quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
 
 	/* send message to nsd */
-	if (wlandev->mlmerequest == NULL)
+	if (!wlandev->mlmerequest)
 		return -EOPNOTSUPP;
 
 	result = wlandev->mlmerequest(wlandev, (struct p80211msg *)&quality);
--
1.8.2.3
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915080438.GA6782%40sandhya.
For more options, visit https://groups.google.com/d/optout.