Staging: ethernet: Fixes checkpatch blank lines warnings

PATCH In review Ronald Rojas 3 participants 3 messages Sep 15, 2016 Staging

lore

Share & tools

lore

Ronald Rojas

author

2016-09-15 12:24 UTC #0 lore raw

PATCH 1/1 Staging: ethernet: Fixes checkpatch blank lines warnings

Fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines

Signed-off-by Ronald Rojas <[email protected]>

---
v5: changes to commit log

 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/staging/octeon/ethernet.c +0 -3

index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *

@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();

@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();

Signature · 1 line

2.7.4

Arnd Bergmann

2016-09-15 12:29 UTC #1 lore raw

Quoted 4 lines · CEST Ronald Rojas

Fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines
Signed-off-by Ronald Rojas <[email protected]>

In the subject line, please use "octeon" instead of "ethernet".

Did you build test this driver using a MIPS cross-compiler? I realize that it's just a whitespace change and it clearly won't break anything, but in general you should do some build testing before sending it out, and properly building this driver is a bit tricky.

Arnd

Julia Lawall

2016-09-15 12:37 UTC #2 lore raw

Quoted 7 lines · Arnd Bergmann

Quoted 4 lines · CEST Ronald Rojas
Fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines
Signed-off-by Ronald Rojas <[email protected]>
In the subject line, please use "octeon" instead of "ethernet".

In general, you can't make up your own formula for creating the subject line. You have to see what others have done, because different subsystems use different strategies. To see what others have done, do:

git log --oneline filename.c

julia

Quoted 16 lines

Did you build test this driver using a MIPS cross-compiler? I realize that it's just a whitespace change and it clearly won't break anything, but in general you should do some build testing before sending it out, and properly building this driver is a bit tricky.
Arnd
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/15778561.A1ImvO0lIj%40wuerfel.
For more options, visit https://groups.google.com/d/optout.