Skip to contentSkip to conversation

x86: baytrail: Add 2nd eMMC controller to the PCI probe list

PATCH New Stefan Roese 2 participants 4 messages Sep 16, 2016 – Sep 26, 2016 x86

lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 x86: baytrail: Add 2nd eMMC controller to the PCI probe list

With this addition, the eMMC device available on the congatec and DFI BayTrail SoM is detected correctly.

Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
---
 arch/x86/cpu/baytrail/valleyview.c | 1 +
 include/pci_ids.h                  | 1 +
 2 files changed, 2 insertions(+)
arch/x86/cpu/baytrail/valleyview.c +1 -0
index b31f24e..9868de0 100644
@@ -14,6 +14,7 @@
 static struct pci_device_id mmc_supported[] = {
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },
 	{},
 };
include/pci_ids.h +1 -0
index 17a01a0..e63b94f 100644
@@ -2606,6 +2606,7 @@
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_IDE_ALT	0x0f21
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA	0x0f22
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA_ALT	0x0f23
+#define PCI_DEVICE_ID_INTEL_BYT_EMMC2	0x0f50
 #define PCI_DEVICE_ID_INTEL_82541ER	0x1078
 #define PCI_DEVICE_ID_INTEL_82541GI_LF	0x107c
 #define PCI_DEVICE_ID_INTEL_82542	0x1000
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 x86: baytrail: Add 2nd eMMC controller to the PCI probe list

Hi Stefan,

Quoted 16 lines · Stefan Roese

With this addition, the eMMC device available on the congatec and DFI BayTrail SoM is detected correctly.

Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
---
 arch/x86/cpu/baytrail/valleyview.c | 1 +
 include/pci_ids.h                  | 1 +
 2 files changed, 2 insertions(+)
arch/x86/cpu/baytrail/valleyview.c +0 -0
index b31f24e..9868de0 100644

arch/x86/cpu/baytrail/valleyview.c line 17

Quoted 4 lines
arch/x86/cpu/baytrail/valleyview.c +1 -0
@@ -14,6 +14,7 @@
 static struct pci_device_id mmc_supported[] = {
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },

pure nits, should we use VALLEYVIEW_EMMC2? or should we change previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

Quoted 8 lines
arch/x86/cpu/baytrail/valleyview.c +0 -0
        {},
 };
include/pci_ids.h +0 -0
index 17a01a0..e63b94f 100644

include/pci_ids.h

Quoted 8 lines
include/pci_ids.h +1 -1
@@ -2606,6 +2606,7 @@
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_IDE_ALT 0x0f21
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA    0x0f22
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA_ALT        0x0f23
+#define PCI_DEVICE_ID_INTEL_BYT_EMMC2  0x0f50
 #define PCI_DEVICE_ID_INTEL_82541ER    0x1078
 #define PCI_DEVICE_ID_INTEL_82541GI_LF 0x107c
 #define PCI_DEVICE_ID_INTEL_82542      0x1000
--

Regards,
Bin

author
#2 lore raw

PATCH 1/1 x86: baytrail: Add 2nd eMMC controller to the PCI probe list

Hi Bin,

Quoted 12 lines · Bin Meng
Quoted 11 lines · Stefan Roese

With this addition, the eMMC device available on the congatec and DFI BayTrail SoM is detected correctly.

Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
---
 arch/x86/cpu/baytrail/valleyview.c | 1 +
 include/pci_ids.h                  | 1 +
 2 files changed, 2 insertions(+)
Quoted 12 lines

arch/x86/cpu/baytrail/valleyview.c line 17

Quoted 9 lines
arch/x86/cpu/baytrail/valleyview.c +1 -0
index b31f24e..9868de0 100644
@@ -14,6 +14,7 @@
 static struct pci_device_id mmc_supported[] = {
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },

pure nits, should we use VALLEYVIEW_EMMC2? or should we change previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

I've taken the new name from the Linux driver as you might have already suspected. I would prefer to change the other (old) names to the Linux ones. I can prepare a v2 of this patch or a follow-up patch for this. What would you prefer?

Thanks,
Stefan

#3 lore raw

PATCH 1/1 x86: baytrail: Add 2nd eMMC controller to the PCI probe list

Hi Stefan,

Quoted 33 lines · Stefan Roese

Hi Bin,

Quoted 14 lines · Bin Meng
Quoted 12 lines · Stefan Roese

With this addition, the eMMC device available on the congatec and DFI BayTrail SoM is detected correctly.

Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
---
 arch/x86/cpu/baytrail/valleyview.c | 1 +
 include/pci_ids.h                  | 1 +
 2 files changed, 2 insertions(+)
Quoted 14 lines

arch/x86/cpu/baytrail/valleyview.c line 17

Quoted 10 lines
arch/x86/cpu/baytrail/valleyview.c +1 -0
index b31f24e..9868de0 100644
@@ -14,6 +14,7 @@
 static struct pci_device_id mmc_supported[] = {
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },

pure nits, should we use VALLEYVIEW_EMMC2? or should we change previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

Quoted 5 lines

I've taken the new name from the Linux driver as you might have already suspected. I would prefer to change the other (old) names to the Linux ones. I can prepare a v2 of this patch or a follow-up patch for this. What would you prefer?

Sure, let's match Linux.

Regards,
Bin