Staging: i4l: Remove NULL comparison.
PATCH 1/1 Staging: i4l: Remove NULL comparison.
Remove NULL comparison with ! operator.
This patch removes the explicit NULL comparison.
This issue was found by checkpatch.pl script.
--- drivers/staging/i4l/act2000/act2000_isa.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/i4l/act2000/act2000_isa.c +2 -2
@@ -166,7 +166,7 @@ act2000_isa_config_port(act2000_card *card, unsigned short portbase)release_region (card->port,ISA_REGION ); card->flags &= ~ACT2000_FLAGS_PVALID ; } -if (request_region (portbase,ACT2000_PORTLEN , card->regname) ==NULL ) +if (!request_region (portbase,ACT2000_PORTLEN , card->regname))return -EBUSY ;else { card->port = portbase;
@@ -244,7 +244,7 @@ act2000_isa_receive(act2000_card *card)if (valid) { card->idat.isa.rcvlen = ((actcapi_msghdr *)&card->idat.isa.rcvhdr)->len; card->idat.isa.rcvskb =dev_alloc_skb (card->idat.isa.rcvlen); -if (card->idat.isa.rcvskb ==NULL ) { +if (!card->idat.isa.rcvskb) { card->idat.isa.rcvignore =1 ;printk (KERN_WARNING "act2000_isa_receive: no memory\n" );
Signature · 1 line
1.7.1
Quoted 2 lines · Sandhya Bankar
Remove NULL comparison with ! operator.
This patch removes the explicit NULL comparison.
The first two sentences seem to say the same thing? Actually, the first one is ambiguous. It looks like NULL is being compared to !.
julia
Quoted 40 lines
This issue was found by checkpatch.pl script.
Signed-off-by Sandhya Bankar <[email protected]>--- drivers/staging/i4l/act2000/act2000_isa.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/i4l/act2000/act2000_isa.c +2
-3@@ -166,7 +166,7 @@ act2000_isa_config_port(act2000_card *card, unsigned short portbase)release_region (card->port,ISA_REGION ); card->flags &= ~ACT2000_FLAGS_PVALID ; } -if (request_region (portbase,ACT2000_PORTLEN , card->regname) ==NULL ) +if (!request_region (portbase,ACT2000_PORTLEN , card->regname))return -EBUSY ;else { card->port = portbase;@@ -244,7 +244,7 @@ act2000_isa_receive(act2000_card *card)if (valid) { card->idat.isa.rcvlen = ((actcapi_msghdr *)&card->idat.isa.rcvhdr)->len; card->idat.isa.rcvskb =dev_alloc_skb (card->idat.isa.rcvlen); -if (card->idat.isa.rcvskb ==NULL ) { +if (!card->idat.isa.rcvskb) { card->idat.isa.rcvignore =1 ;printk (KERN_WARNING "act2000_isa_receive: no memory\n" ); --1.7.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917002853.GA14373%40sandhya.
For more options, visit https://groups.google.com/d/optout.