drm: include linux/seq_file.h as needed
Subsystems (2)
PATCH 1/1 drm: include linux/seq_file.h as needed
The addition of the debugfs info created references to seq_puts() and seq_printf(), but relied on the debugfs header to be included implicitly, which apparently doesn't happen all the time, as seen from this randconfig build output:
drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration] drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
Adding the extra include brings back a clean build.
--- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_dp_helper.c +1 -0
@@ -27,6 +27,7 @@#include <linux/errno.h> #include <linux/sched.h> #include <linux/i2c.h> +#include <linux/seq_file.h> #include <drm/drm_dp_helper.h> #include <drm/drmP.h>
Signature · 6 lines
2.9.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Arnd Bergmann
The addition of the debugfs info created references to
seq_puts()andseq_printf(), but relied on the debugfs header to be included implicitly, which apparently doesn't happen all the time, as seen from this randconfig build output:
drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]Adding the extra include brings back a clean build.
Beat you to it, but no review/acks...
http://patchwork.freedesktop.org/patch/msgid/[email protected]
BR,
Jani.
Quoted 18 lines
Fixes 80209e5f2c42 ("drm: Add DP branch device info on debugfs")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/drm_dp_helper.c +1
-0@@ -27,6 +27,7 @@#include <linux/errno.h> #include <linux/sched.h> #include <linux/i2c.h> +#include <linux/seq_file.h> #include <drm/drm_dp_helper.h> #include <drm/drmP.h>
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel